Skip to content

continue crashes tests -Znext-solver work - #163796

Merged
rust-bors[bot] merged 11 commits into
rust-lang:mainfrom
lcnr:crashes-migration
Oct 5, 2026
Merged

continue crashes tests -Znext-solver work#163796
rust-bors[bot] merged 11 commits into
rust-lang:mainfrom
lcnr:crashes-migration

Conversation

@lcnr

@lcnr lcnr commented Oct 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

@rustbot

rustbot commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 5, 2026
@rustbot

rustbot commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 77 candidates
  • Random selection from 17 candidates

@lqd

lqd commented Oct 5, 2026

Copy link
Copy Markdown
Member

I'll take this, r? me

@rustbot rustbot assigned lqd and unassigned petrochenkov Oct 5, 2026
@lcnr lcnr mentioned this pull request Oct 5, 2026
Merged
@lcnr lcnr closed this Oct 5, 2026
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 5, 2026
@lcnr lcnr reopened this Oct 5, 2026
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 5, 2026
lqd
lqd approved these changes Oct 5, 2026
View reviewed changes

@lqd lqd left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, r=me

View changes since this review

Comment thread tests/ui/async-await/witness-auto-trait/witness-lifetime-dependent-auto-trait-119095.rs
Comment on lines +11 to +12
// Regression test for #119095. No clue why this does not fail
// to compile with the new solver. Likely because we normalize

@lqd lqd Oct 5, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no clue why this does not fail

do we want investigate this w/ new solver or not? (I dunno, a new E-needs-help issue, having a known-bug in the test, etc). It feels unlikely to cause issues in practice, so it seems fine?

@lcnr lcnr Oct 5, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel like it 🤔 I am fairly confident in my "likely because X" here and expect that looking into this is both hard, and not worth the effort.

"No clue why this does not fail to compile with the new solver" is kind of iffy here 🤔 don't want to bother to change this again, gonna keep it as is

Comment thread tests/crashes/102047.rs Outdated

@lqd lqd Oct 5, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(if anyone ever reads this via GH history and is confused, the crashtest is a duplicate of another issue, so that MCVE was added in our tests rather than this crashes test)

@lcnr

lcnr commented Oct 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@bors r=lqd rollup=iffy (touches a lot of tests)

@rust-bors

rust-bors Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

❌ Cannot approve commit 612d3d9, because CI currently fails on this PR. Use @bors r+ force to override the PR CI check.

@lcnr lcnr closed this Oct 5, 2026
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 5, 2026
@lcnr lcnr reopened this Oct 5, 2026
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 5, 2026
@lcnr

lcnr commented Oct 5, 2026

Copy link
Copy Markdown
Contributor Author

@bors r=lqd rollup=iffy

@rust-bors

rust-bors Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

❌ Cannot approve commit 612d3d9, because CI currently fails on this PR. Use @bors r+ force to override the PR CI check.

@lqd

lqd commented Oct 5, 2026

Copy link
Copy Markdown
Member

@bors r+

@rust-bors

rust-bors Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

❌ Cannot approve commit 612d3d9, because CI currently fails on this PR. Use @bors r+ force to override the PR CI check.

@lqd

lqd commented Oct 5, 2026

Copy link
Copy Markdown
Member

@bors r+ force

@rust-bors

rust-bors Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 612d3d9 has been approved by lqd

It is now in the queue for this repository.

Warning

This PR was force-approved despite failing PR CI.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 5, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Oct 5, 2026
@JonathanBrouwer
Rollup merge of rust-lang#163796 - lcnr:crashes-migration, r=lqd
1d93934 
continue crashes tests `-Znext-solver` work

cc rust-lang#140211 rust-lang#119786 rust-lang#155497 rust-lang#110534 rust-lang#102252 rust-lang#120254 rust-lang#115435 rust-lang#122529 rust-lang#119095 rust-lang#124440
@JonathanBrouwer JonathanBrouwer mentioned this pull request Oct 5, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Oct 5, 2026
@bors
Auto merge of #163827 - JonathanBrouwer:rollup-miFdVKH, r=JonathanBro…
a93d401 
…uwer

Rollup of 12 pull requests

Successful merges:

 - #163531 (rustc_ast_lowering: track implicit Self via explicit flag instead of name)
 - #160915 ([rustdoc] Fix how `Deref` items is handled.)
 - #163364 (make semicolon_in_expressions_from_non_local_macros not report-in-deps)
 - #163770 (document the rustc_comptime attribute)
 - #163780 (Skip optional asserts in SsaRangePropagation)
 - #163785 (Bump Windows CI LLVM to 22.1.8)
 - #163796 (continue crashes tests `-Znext-solver` work)
 - #163646 (Get `inputs_hir` directly from `decl`)
 - #163733 (Fix extra spaces in integer format_into docs)
 - #163773 (Update GitHub Actions to v26)
 - #163787 (moves rustc_legacy_const_generics checks into attribute parsing)
 - #163810 (Fix an issue for clippy's `search_is_some` with the next-solver)
@JonathanBrouwer JonathanBrouwer mentioned this pull request Oct 5, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Oct 5, 2026
@bors
Auto merge of #163829 - JonathanBrouwer:rollup-8dFIE96, r=JonathanBro…
ea13733 
…uwer

Rollup of 11 pull requests

Successful merges:

 - #163364 (make semicolon_in_expressions_from_non_local_macros not report-in-deps)
 - #163531 (rustc_ast_lowering: track implicit Self via explicit flag instead of name)
 - #163770 (document the rustc_comptime attribute)
 - #163780 (Skip optional asserts in SsaRangePropagation)
 - #163785 (Bump Windows CI LLVM to 22.1.8)
 - #163796 (continue crashes tests `-Znext-solver` work)
 - #163646 (Get `inputs_hir` directly from `decl`)
 - #163733 (Fix extra spaces in integer format_into docs)
 - #163773 (Update GitHub Actions to v26)
 - #163787 (moves rustc_legacy_const_generics checks into attribute parsing)
 - #163810 (Fix an issue for clippy's `search_is_some` with the next-solver)
@rust-bors
rust-bors Bot merged commit 431aebf into rust-lang:main Oct 5, 2026
41 of 56 checks passed
@rustbot rustbot added this to the 1.101.0 milestone Oct 5, 2026
rust-bors Bot pushed a commit that referenced this pull request Oct 5, 2026
@bors
Unrolled build for #163796 in rollup 163829
6f0779e 
Rollup merge of #163796 - lcnr:crashes-migration, r=lqd

continue crashes tests `-Znext-solver` work

cc #140211 #119786 #155497 #110534 #102252 #120254 #115435 #122529 #119095 #124440
@lcnr
lcnr deleted the crashes-migration branch October 5, 2026 20:58
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Oct 7, 2026
@JonathanBrouwer
Rollup merge of rust-lang#163806 - lcnr:crashes-migration-cont, r=lqd
464d1a2 
even more `tests/crashes` migration for `-Znext-solver`

cc https://hackmd.io/ydc_nIbHQqG-ctMDapXYTg continuing the work of rust-lang#163796

relevant issues:
- rust-lang#126680 still broken due to rust-lang/trait-system-refactor-initiative#303
- rust-lang#140850
- rust-lang#125553
- rust-lang#123157 duplicate of rust-lang#125553
- rust-lang#131886 still broken due to rust-lang/trait-system-refactor-initiative#303
- rust-lang#135617
- rust-lang#129372
- rust-lang#134838
- rust-lang#131373
- rust-lang#136666 duplicate of rust-lang#124440
- rust-lang#127033
- rust-lang#130797 duplicate of rust-lang#140211
- rust-lang#135122
- rust-lang#135718
- rust-lang#139381
- rust-lang#138707
- rust-lang#130524 duplicate of rust-lang#140211
- rust-lang#147719 instance of rust-lang#110534
- rust-lang#148094 duplicate of rust-lang#131886
- rust-lang#139120 duplicate of rust-lang#140211
- rust-lang#146965 instance of lcnr/random-rust-snippets#23
- rust-lang#149015
- rust-lang#148095
- rust-lang#150263 duplicate of rust-lang#146965
- rust-lang#150517 duplicate of rust-lang#149015
- rust-lang#151069
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Oct 7, 2026
@JonathanBrouwer
Rollup merge of rust-lang#163806 - lcnr:crashes-migration-cont, r=lqd
7b33779 
even more `tests/crashes` migration for `-Znext-solver`

cc https://hackmd.io/ydc_nIbHQqG-ctMDapXYTg continuing the work of rust-lang#163796

relevant issues:
- rust-lang#126680 still broken due to rust-lang/trait-system-refactor-initiative#303
- rust-lang#140850
- rust-lang#125553
- rust-lang#123157 duplicate of rust-lang#125553
- rust-lang#131886 still broken due to rust-lang/trait-system-refactor-initiative#303
- rust-lang#135617
- rust-lang#129372
- rust-lang#134838
- rust-lang#131373
- rust-lang#136666 duplicate of rust-lang#124440
- rust-lang#127033
- rust-lang#130797 duplicate of rust-lang#140211
- rust-lang#135122
- rust-lang#135718
- rust-lang#139381
- rust-lang#138707
- rust-lang#130524 duplicate of rust-lang#140211
- rust-lang#147719 instance of rust-lang#110534
- rust-lang#148094 duplicate of rust-lang#131886
- rust-lang#139120 duplicate of rust-lang#140211
- rust-lang#146965 instance of lcnr/random-rust-snippets#23
- rust-lang#149015
- rust-lang#148095
- rust-lang#150263 duplicate of rust-lang#146965
- rust-lang#150517 duplicate of rust-lang#149015
- rust-lang#151069
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Oct 7, 2026
@JonathanBrouwer
Rollup merge of rust-lang#163806 - lcnr:crashes-migration-cont, r=lqd
1760e75 
even more `tests/crashes` migration for `-Znext-solver`

cc https://hackmd.io/ydc_nIbHQqG-ctMDapXYTg continuing the work of rust-lang#163796

relevant issues:
- rust-lang#126680 still broken due to rust-lang/trait-system-refactor-initiative#303
- rust-lang#140850
- rust-lang#125553
- rust-lang#123157 duplicate of rust-lang#125553
- rust-lang#131886 still broken due to rust-lang/trait-system-refactor-initiative#303
- rust-lang#135617
- rust-lang#129372
- rust-lang#134838
- rust-lang#131373
- rust-lang#136666 duplicate of rust-lang#124440
- rust-lang#127033
- rust-lang#130797 duplicate of rust-lang#140211
- rust-lang#135122
- rust-lang#135718
- rust-lang#139381
- rust-lang#138707
- rust-lang#130524 duplicate of rust-lang#140211
- rust-lang#147719 instance of rust-lang#110534
- rust-lang#148094 duplicate of rust-lang#131886
- rust-lang#139120 duplicate of rust-lang#140211
- rust-lang#146965 instance of lcnr/random-rust-snippets#23
- rust-lang#149015
- rust-lang#148095
- rust-lang#150263 duplicate of rust-lang#146965
- rust-lang#150517 duplicate of rust-lang#149015
- rust-lang#151069
rust-bors Bot pushed a commit that referenced this pull request Oct 8, 2026
@bors
Unrolled build for #163806 in rollup 163957
169ad55 
Rollup merge of #163806 - lcnr:crashes-migration-cont, r=lqd

even more `tests/crashes` migration for `-Znext-solver`

cc https://hackmd.io/ydc_nIbHQqG-ctMDapXYTg continuing the work of #163796

relevant issues:
- #126680 still broken due to rust-lang/trait-system-refactor-initiative#303
- #140850
- #125553
- #123157 duplicate of #125553
- #131886 still broken due to rust-lang/trait-system-refactor-initiative#303
- #135617
- #129372
- #134838
- #131373
- #136666 duplicate of #124440
- #127033
- #130797 duplicate of #140211
- #135122
- #135718
- #139381
- #138707
- #130524 duplicate of #140211
- #147719 instance of #110534
- #148094 duplicate of #131886
- #139120 duplicate of #140211
- #146965 instance of lcnr/random-rust-snippets#23
- #149015
- #148095
- #150263 duplicate of #146965
- #150517 duplicate of #149015
- #151069
@lcnr lcnr mentioned this pull request Oct 8, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lqd lqd lqd approved these changes

Assignees

@lqd lqd

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.101.0

Development

Successfully merging this pull request may close these issues.

4 participants

@lcnr @rustbot @lqd @petrochenkov