Skip to content

replace fully_monomorphized with cx.typing_env() - #163745

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
lcnr:use-existing-typing-env-where-possible
Oct 9, 2026
Merged

replace fully_monomorphized with cx.typing_env()#163745
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
lcnr:use-existing-typing-env-where-possible

Conversation

@lcnr

@lcnr lcnr commented Oct 4, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

cc #163724

reasoning about whether a given TypingEnv is correct is non-trivial, so if we've got a context which already provides the correct TypingEnv, using that is easier.

@rustbot

rustbot commented Oct 4, 2026

Copy link
Copy Markdown
Collaborator

rustc_codegen_cranelift is developed in its own repository. If possible, consider making this change to rust-lang/rustc_codegen_cranelift instead.

cc @bjorn3

rustc_codegen_gcc is developed in its own repository. If possible, consider making this change to rust-lang/rustc_codegen_gcc instead.

cc @antoyo, @GuillaumeGomez

Some changes occurred in compiler/rustc_codegen_llvm/src/builder/autodiff.rs

cc @ZuseZ4

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. F-autodiff `#![feature(autodiff)]` S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 4, 2026
@rustbot

rustbot commented Oct 4, 2026

Copy link
Copy Markdown
Collaborator

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 77 candidates
  • Random selection from 18 candidates

@lcnr
lcnr force-pushed the use-existing-typing-env-where-possible branch from b7174f9 to 730680c Compare October 4, 2026 09:40
@lcnr
lcnr force-pushed the use-existing-typing-env-where-possible branch from 730680c to b6d09f9 Compare October 4, 2026 09:42
adwinwhite
adwinwhite approved these changes Oct 9, 2026
View reviewed changes

@adwinwhite adwinwhite left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The less typing env construction, the better.

r? me
@bors r+ rollup

View changes since this review

@rust-bors

rust-bors Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

📌 Commit b6d09f9 has been approved by adwinwhite

It is now in the queue for this repository.

@rust-bors rust-bors Bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 9, 2026
@rust-bors rust-bors Bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 9, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Oct 9, 2026
@JonathanBrouwer
Rollup merge of rust-lang#163745 - lcnr:use-existing-typing-env-where…
7debc60 
…-possible, r=adwinwhite

replace `fully_monomorphized` with `cx.typing_env()`

cc rust-lang#163724

reasoning about whether a given `TypingEnv` is correct is non-trivial, so if we've got a context which already provides the correct `TypingEnv`, using that is easier.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Oct 9, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Oct 9, 2026
@bors
Auto merge of #164015 - JonathanBrouwer:rollup-PUjxXQg, r=JonathanBro…
2a9b309 
…uwer

Rollup of 7 pull requests

Successful merges:

 - #162652 (Syntactically reject leading parenthesized precise capturing lists in bare trait object types (`(use<…>)+`))
 - #163337 (MIR move elimination [3/6]: PreciseLiveness)
 - #163954 (fix(bootstrap/darwin): fix rpath for distributed LLD)
 - #163956 (Pass the unremapped path to the `rustc` invocation for doctests)
 - #163634 (move overflow lint computation into decorator)
 - #163727 (rigid aliases to non-rigid for fully normalized check)
 - #163745 (replace `fully_monomorphized` with `cx.typing_env()`)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Oct 9, 2026
@JonathanBrouwer
Rollup merge of rust-lang#163745 - lcnr:use-existing-typing-env-where…
249b8e2 
…-possible, r=adwinwhite

replace `fully_monomorphized` with `cx.typing_env()`

cc rust-lang#163724

reasoning about whether a given `TypingEnv` is correct is non-trivial, so if we've got a context which already provides the correct `TypingEnv`, using that is easier.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Oct 9, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Oct 9, 2026
@bors
Auto merge of #164024 - JonathanBrouwer:rollup-m4RSe7r, r=JonathanBro…
db1eb3f 
…uwer

Rollup of 11 pull requests

Successful merges:

 - #162652 (Syntactically reject leading parenthesized precise capturing lists in bare trait object types (`(use<…>)+`))
 - #163337 (MIR move elimination [3/6]: PreciseLiveness)
 - #163954 (fix(bootstrap/darwin): fix rpath for distributed LLD)
 - #163956 (Pass the unremapped path to the `rustc` invocation for doctests)
 - #163634 (move overflow lint computation into decorator)
 - #163666 (Updates the expect message library/core/src/time.rs)
 - #163727 (rigid aliases to non-rigid for fully normalized check)
 - #163745 (replace `fully_monomorphized` with `cx.typing_env()`)
 - #164000 (When mentioning that closure doesn't implement trait, point at closure)
 - #164007 ([rustdoc] Prefer local paths over remote ones when foreign item is locally reexported)
 - #164017 (cg_llvm: Avoid some explicit casts to `*const c_char`)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Oct 9, 2026
@JonathanBrouwer
Rollup merge of rust-lang#163745 - lcnr:use-existing-typing-env-where…
39f76d4 
…-possible, r=adwinwhite

replace `fully_monomorphized` with `cx.typing_env()`

cc rust-lang#163724

reasoning about whether a given `TypingEnv` is correct is non-trivial, so if we've got a context which already provides the correct `TypingEnv`, using that is easier.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Oct 9, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Oct 9, 2026
@JonathanBrouwer
Rollup merge of rust-lang#163745 - lcnr:use-existing-typing-env-where…
2c802e2 
…-possible, r=adwinwhite

replace `fully_monomorphized` with `cx.typing_env()`

cc rust-lang#163724

reasoning about whether a given `TypingEnv` is correct is non-trivial, so if we've got a context which already provides the correct `TypingEnv`, using that is easier.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Oct 9, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Oct 9, 2026
@bors
Auto merge of #164027 - JonathanBrouwer:rollup-krSHJf8, r=JonathanBro…
5558512 
…uwer

Rollup of 14 pull requests

Successful merges:

 - #162652 (Syntactically reject leading parenthesized precise capturing lists in bare trait object types (`(use<…>)+`))
 - #163337 (MIR move elimination [3/6]: PreciseLiveness)
 - #163954 (fix(bootstrap/darwin): fix rpath for distributed LLD)
 - #163193 (cfi: mangle `f128` as `e` rather than `g` on platforms without `_Float128`)
 - #163634 (move overflow lint computation into decorator)
 - #163666 (Updates the expect message library/core/src/time.rs)
 - #163727 (rigid aliases to non-rigid for fully normalized check)
 - #163745 (replace `fully_monomorphized` with `cx.typing_env()`)
 - #163912 (Fix debug assert failure in `note_obligation_cause_code_inner`)
 - #163972 (const-eval: ICE when we hit a non-const fn)
 - #164000 (When mentioning that closure doesn't implement trait, point at closure)
 - #164007 ([rustdoc] Prefer local paths over remote ones when foreign item is locally reexported)
 - #164017 (cg_llvm: Avoid some explicit casts to `*const c_char`)
 - #164025 (Less `CanonicalVarValues`)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Oct 9, 2026
@JonathanBrouwer
Rollup merge of rust-lang#163745 - lcnr:use-existing-typing-env-where…
a5e5aa6 
…-possible, r=adwinwhite

replace `fully_monomorphized` with `cx.typing_env()`

cc rust-lang#163724

reasoning about whether a given `TypingEnv` is correct is non-trivial, so if we've got a context which already provides the correct `TypingEnv`, using that is easier.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Oct 9, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Oct 9, 2026
@bors
Auto merge of #164039 - JonathanBrouwer:rollup-IE4YJ5b, r=JonathanBro…
e61399a 
…uwer

Rollup of 14 pull requests

Successful merges:

 - #162652 (Syntactically reject leading parenthesized precise capturing lists in bare trait object types (`(use<…>)+`))
 - #163337 (MIR move elimination [3/6]: PreciseLiveness)
 - #163954 (fix(bootstrap/darwin): fix rpath for distributed LLD)
 - #163193 (cfi: mangle `f128` as `e` rather than `g` on platforms without `_Float128`)
 - #163634 (move overflow lint computation into decorator)
 - #163666 (Updates the expect message library/core/src/time.rs)
 - #163727 (rigid aliases to non-rigid for fully normalized check)
 - #163745 (replace `fully_monomorphized` with `cx.typing_env()`)
 - #163912 (Fix debug assert failure in `note_obligation_cause_code_inner`)
 - #163950 (don't treat inherited opaques as defining)
 - #164000 (When mentioning that closure doesn't implement trait, point at closure)
 - #164007 ([rustdoc] Prefer local paths over remote ones when foreign item is locally reexported)
 - #164017 (cg_llvm: Avoid some explicit casts to `*const c_char`)
 - #164025 (Less `CanonicalVarValues`)
@JonathanBrouwer JonathanBrouwer mentioned this pull request Oct 9, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Oct 9, 2026
@bors
Auto merge of #164052 - JonathanBrouwer:rollup-ajP9YeO, r=JonathanBro…
32dba69 
…uwer

Rollup of 24 pull requests

Successful merges:

 - #161998 ( Support type-relative assoc item paths in generic param defaults & const param types)
 - #162106 (Helpful suggestions for incorrect address-of mutability (2))
 - #162652 (Syntactically reject leading parenthesized precise capturing lists in bare trait object types (`(use<…>)+`))
 - #163337 (MIR move elimination [3/6]: PreciseLiveness)
 - #163938 (-Zassumptions-on-binders: rewrite alias outlives constraints more goodly)
 - #163939 (Better debug impls for some assumptions on binders types)
 - #163954 (fix(bootstrap/darwin): fix rpath for distributed LLD)
 - #163956 (Pass the unremapped path to the `rustc` invocation for doctests)
 - #164042 (Allow testing cg-gcc on any target)
 - #162443 (Do not retain `Normalization` goal errors in nested goals for `BestObligationVisitor:: non_trivial_candidates `)
 - #162908 (Fix - const parameters rejected when identical)
 - #163193 (cfi: mangle `f128` as `e` rather than `g` on platforms without `_Float128`)
 - #163634 (move overflow lint computation into decorator)
 - #163666 (Updates the expect message library/core/src/time.rs)
 - #163727 (rigid aliases to non-rigid for fully normalized check)
 - #163745 (replace `fully_monomorphized` with `cx.typing_env()`)
 - #163912 (Fix debug assert failure in `note_obligation_cause_code_inner`)
 - #163950 (don't treat inherited opaques as defining)
 - #163972 (const-eval: ICE when we hit a non-const fn)
 - #164000 (When mentioning that closure doesn't implement trait, point at closure)
 - #164007 ([rustdoc] Prefer local paths over remote ones when foreign item is locally reexported)
 - #164008 (properly ignore the current goal's usages)
 - #164017 (cg_llvm: Avoid some explicit casts to `*const c_char`)
 - #164025 (Less `CanonicalVarValues`)
@rust-bors
rust-bors Bot merged commit b1d9885 into rust-lang:main Oct 9, 2026
14 checks passed
@rustbot rustbot added this to the 1.101.0 milestone Oct 9, 2026
rust-bors Bot pushed a commit that referenced this pull request Oct 9, 2026
@bors
Unrolled build for #163745 in rollup 164052
9175978 
Rollup merge of #163745 - lcnr:use-existing-typing-env-where-possible, r=adwinwhite

replace `fully_monomorphized` with `cx.typing_env()`

cc #163724

reasoning about whether a given `TypingEnv` is correct is non-trivial, so if we've got a context which already provides the correct `TypingEnv`, using that is easier.
@adwinwhite adwinwhite mentioned this pull request Oct 10, 2026
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adwinwhite adwinwhite adwinwhite approved these changes

Assignees

@adwinwhite adwinwhite

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. F-autodiff `#![feature(autodiff)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.101.0

Development

Successfully merging this pull request may close these issues.

4 participants

@lcnr @rustbot @adwinwhite @wesleywiser