rigid aliases to non-rigid for fully normalized check by lcnr · Pull Request #163727 · rust-lang/rust

lcnr · 2026-10-03T22:21:27Z

otherwise we incorrectly mark #163724 / #152416 as fixed with the new solver 😅

r? adwinwhite

rustbot · 2026-10-03T22:21:32Z

adwinwhite is currently at their maximum review capacity.
They may take a while to respond.

adwinwhite · 2026-10-08T06:10:13Z

@bors try @rust-timer queue

rigid aliases to non-rigid for fully normalized check

adwinwhite · 2026-10-08T06:16:05Z

-                value.clone(),
-                value.fold_with(&mut NormalizeAfterErasingRegionsFolder { tcx: self, typing_env })
-            )
+            let normalized = ty::set_aliases_to_non_rigid(self, value.clone())


This guards against uncaught typing env change? Should we have some comments here?

View changes since the review

adwinwhite · 2026-10-08T06:17:34Z


            // Anything else would be completely captured and therefore handled already.
-            _ => unreachable!(),
+            _ => unreachable!("unexpected base_path_ty: {base_path_ty:?}",),


is this accidental commit? doesn't really matter though.

View changes since the review

unrelated change while triaging ui tests, don't want to split this out into a separate commit

rust-bors · 2026-10-08T07:13:16Z

☀️ Try build successful (CI)
Build commit: f6de27a (f6de27ae4d122446e0648e6106e61be79a8b74db)
Base parent: 36aeef3 (36aeef32c6c012e1af17af53a820aac042846c43)

rustbot · 2026-10-08T07:27:22Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

rust-timer · 2026-10-08T08:05:20Z

Finished benchmarking commit (f6de27a): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.1%, 0.1%]	1
Regressions ❌ (secondary)	0.1%	[0.1%, 0.1%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[0.1%, 0.1%]	1

Max RSS (memory usage)

Results (primary 3.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.6%	[2.1%, 5.1%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.6%	[2.1%, 5.1%]	2

Cycles

Results (primary 1.3%, secondary 2.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.2%	[2.2%, 4.1%]	2
Regressions ❌ (secondary)	2.5%	[2.4%, 2.5%]	2
Improvements ✅ (primary)	-2.4%	[-2.4%, -2.4%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.3%	[-2.4%, 4.1%]	3

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 490.639s -> 489.962s (-0.14%)
Artifact size: 408.64 MiB -> 408.60 MiB (-0.01%)

lcnr · 2026-10-08T08:27:34Z

should be spurious

adwinwhite · 2026-10-09T01:29:49Z

spurious or we're indeed doing a little bit more work.

@bors r+ rollup

rust-bors · 2026-10-09T01:29:52Z

📌 Commit 6ddabeb has been approved by adwinwhite

It is now in the queue for this repository.

rigid aliases to non-rigid for fully normalized check otherwise we incorrectly mark rust-lang#163724 / rust-lang#152416 as fixed with the new solver 😅 r? adwinwhite

…uwer Rollup of 7 pull requests Successful merges: - #162652 (Syntactically reject leading parenthesized precise capturing lists in bare trait object types (`(use<…>)+`)) - #163337 (MIR move elimination [3/6]: PreciseLiveness) - #163954 (fix(bootstrap/darwin): fix rpath for distributed LLD) - #163956 (Pass the unremapped path to the `rustc` invocation for doctests) - #163634 (move overflow lint computation into decorator) - #163727 (rigid aliases to non-rigid for fully normalized check) - #163745 (replace `fully_monomorphized` with `cx.typing_env()`)

rigid aliases to non-rigid for fully normalized check otherwise we incorrectly mark rust-lang#163724 / rust-lang#152416 as fixed with the new solver 😅 r? adwinwhite

…uwer Rollup of 11 pull requests Successful merges: - #162652 (Syntactically reject leading parenthesized precise capturing lists in bare trait object types (`(use<…>)+`)) - #163337 (MIR move elimination [3/6]: PreciseLiveness) - #163954 (fix(bootstrap/darwin): fix rpath for distributed LLD) - #163956 (Pass the unremapped path to the `rustc` invocation for doctests) - #163634 (move overflow lint computation into decorator) - #163666 (Updates the expect message library/core/src/time.rs) - #163727 (rigid aliases to non-rigid for fully normalized check) - #163745 (replace `fully_monomorphized` with `cx.typing_env()`) - #164000 (When mentioning that closure doesn't implement trait, point at closure) - #164007 ([rustdoc] Prefer local paths over remote ones when foreign item is locally reexported) - #164017 (cg_llvm: Avoid some explicit casts to `*const c_char`)

rigid aliases to non-rigid for fully normalized check otherwise we incorrectly mark rust-lang#163724 / rust-lang#152416 as fixed with the new solver 😅 r? adwinwhite

…uwer Rollup of 14 pull requests Successful merges: - #162652 (Syntactically reject leading parenthesized precise capturing lists in bare trait object types (`(use<…>)+`)) - #163337 (MIR move elimination [3/6]: PreciseLiveness) - #163954 (fix(bootstrap/darwin): fix rpath for distributed LLD) - #163193 (cfi: mangle `f128` as `e` rather than `g` on platforms without `_Float128`) - #163634 (move overflow lint computation into decorator) - #163666 (Updates the expect message library/core/src/time.rs) - #163727 (rigid aliases to non-rigid for fully normalized check) - #163745 (replace `fully_monomorphized` with `cx.typing_env()`) - #163912 (Fix debug assert failure in `note_obligation_cause_code_inner`) - #163972 (const-eval: ICE when we hit a non-const fn) - #164000 (When mentioning that closure doesn't implement trait, point at closure) - #164007 ([rustdoc] Prefer local paths over remote ones when foreign item is locally reexported) - #164017 (cg_llvm: Avoid some explicit casts to `*const c_char`) - #164025 (Less `CanonicalVarValues`)

rigid aliases to non-rigid for fully normalized check otherwise we incorrectly mark rust-lang#163724 / rust-lang#152416 as fixed with the new solver 😅 r? adwinwhite

…uwer Rollup of 14 pull requests Successful merges: - #162652 (Syntactically reject leading parenthesized precise capturing lists in bare trait object types (`(use<…>)+`)) - #163337 (MIR move elimination [3/6]: PreciseLiveness) - #163954 (fix(bootstrap/darwin): fix rpath for distributed LLD) - #163193 (cfi: mangle `f128` as `e` rather than `g` on platforms without `_Float128`) - #163634 (move overflow lint computation into decorator) - #163666 (Updates the expect message library/core/src/time.rs) - #163727 (rigid aliases to non-rigid for fully normalized check) - #163745 (replace `fully_monomorphized` with `cx.typing_env()`) - #163912 (Fix debug assert failure in `note_obligation_cause_code_inner`) - #163950 (don't treat inherited opaques as defining) - #164000 (When mentioning that closure doesn't implement trait, point at closure) - #164007 ([rustdoc] Prefer local paths over remote ones when foreign item is locally reexported) - #164017 (cg_llvm: Avoid some explicit casts to `*const c_char`) - #164025 (Less `CanonicalVarValues`)

…uwer Rollup of 24 pull requests Successful merges: - #161998 ( Support type-relative assoc item paths in generic param defaults & const param types) - #162106 (Helpful suggestions for incorrect address-of mutability (2)) - #162652 (Syntactically reject leading parenthesized precise capturing lists in bare trait object types (`(use<…>)+`)) - #163337 (MIR move elimination [3/6]: PreciseLiveness) - #163938 (-Zassumptions-on-binders: rewrite alias outlives constraints more goodly) - #163939 (Better debug impls for some assumptions on binders types) - #163954 (fix(bootstrap/darwin): fix rpath for distributed LLD) - #163956 (Pass the unremapped path to the `rustc` invocation for doctests) - #164042 (Allow testing cg-gcc on any target) - #162443 (Do not retain `Normalization` goal errors in nested goals for `BestObligationVisitor:: non_trivial_candidates `) - #162908 (Fix - const parameters rejected when identical) - #163193 (cfi: mangle `f128` as `e` rather than `g` on platforms without `_Float128`) - #163634 (move overflow lint computation into decorator) - #163666 (Updates the expect message library/core/src/time.rs) - #163727 (rigid aliases to non-rigid for fully normalized check) - #163745 (replace `fully_monomorphized` with `cx.typing_env()`) - #163912 (Fix debug assert failure in `note_obligation_cause_code_inner`) - #163950 (don't treat inherited opaques as defining) - #163972 (const-eval: ICE when we hit a non-const fn) - #164000 (When mentioning that closure doesn't implement trait, point at closure) - #164007 ([rustdoc] Prefer local paths over remote ones when foreign item is locally reexported) - #164008 (properly ignore the current goal's usages) - #164017 (cg_llvm: Avoid some explicit casts to `*const c_char`) - #164025 (Less `CanonicalVarValues`)

Rollup merge of #163727 - lcnr:check-normalize, r=adwinwhite rigid aliases to non-rigid for fully normalized check otherwise we incorrectly mark #163724 / #152416 as fixed with the new solver 😅 r? adwinwhite

rustbot assigned adwinwhite Oct 3, 2026

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 8, 2026

rust-bors Bot pushed a commit that referenced this pull request Oct 8, 2026

Auto merge of #163727 - lcnr:check-normalize, r=<try>

f6de27a

rigid aliases to non-rigid for fully normalized check

This comment has been minimized.

Sign in to view

adwinwhite reviewed Oct 8, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

lcnr added 2 commits October 8, 2026 09:20

rigid aliases to non-rigid for fully normalized check

34f6848

add comment

6ddabeb

lcnr force-pushed the check-normalize branch from a2cc1d8 to 6ddabeb Compare October 8, 2026 07:27

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 8, 2026

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 8, 2026

rust-bors Bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 9, 2026

JonathanBrouwer mentioned this pull request Oct 9, 2026

Rollup of 7 pull requests #164015

Closed

JonathanBrouwer mentioned this pull request Oct 9, 2026

Rollup of 11 pull requests #164024

Closed

JonathanBrouwer mentioned this pull request Oct 9, 2026

Rollup of 14 pull requests #164026

Closed

JonathanBrouwer mentioned this pull request Oct 9, 2026

Rollup of 14 pull requests #164027

Closed

JonathanBrouwer mentioned this pull request Oct 9, 2026

Rollup of 14 pull requests #164039

Closed

JonathanBrouwer mentioned this pull request Oct 9, 2026

Rollup of 24 pull requests #164052

Merged

rust-bors Bot merged commit b8b41c1 into rust-lang:main Oct 9, 2026
14 checks passed

rustbot added this to the 1.101.0 milestone Oct 9, 2026

Navigation Menu

Repository navigation

rigid aliases to non-rigid for fully normalized check - #163727

rigid aliases to non-rigid for fully normalized check#163727
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
lcnr:check-normalize

lcnr commented Oct 3, 2026 •

edited by rustbot

Loading

Uh oh!

rustbot commented Oct 3, 2026

Uh oh!

adwinwhite commented Oct 8, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

adwinwhite Oct 8, 2026 •

edited by rustbot

Loading

Uh oh!

adwinwhite Oct 8, 2026 •

edited by rustbot

Loading

Uh oh!

lcnr Oct 8, 2026

Uh oh!

rust-bors Bot commented Oct 8, 2026

Uh oh!

This comment has been minimized.

rustbot commented Oct 8, 2026

Uh oh!

rust-timer commented Oct 8, 2026

Uh oh!

lcnr commented Oct 8, 2026

Uh oh!

adwinwhite commented Oct 9, 2026

Uh oh!

rust-bors Bot commented Oct 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

lcnr commented Oct 3, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Oct 3, 2026

Uh oh!

adwinwhite commented Oct 8, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

adwinwhite Oct 8, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adwinwhite Oct 8, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lcnr Oct 8, 2026

Choose a reason for hiding this comment

Uh oh!

rust-bors Bot commented Oct 8, 2026

Uh oh!

This comment has been minimized.

rustbot commented Oct 8, 2026

Uh oh!

rust-timer commented Oct 8, 2026

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

lcnr commented Oct 8, 2026

Uh oh!

adwinwhite commented Oct 9, 2026

Uh oh!

rust-bors Bot commented Oct 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

lcnr commented Oct 3, 2026 •

edited by rustbot

Loading

adwinwhite Oct 8, 2026 •

edited by rustbot

Loading

adwinwhite Oct 8, 2026 •

edited by rustbot

Loading