Skip to content

Rollup of 3 pull requests - #163479

Merged
rust-bors[bot] merged 6 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-vXYZxKq
Sep 29, 2026
Merged

rust-bors[bot] merged 6 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-vXYZxKq

Conversation

@JonathanBrouwer

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost

Create a similar rollup

maxdexh and others added 6 commits September 27, 2026 13:15
…=clarfonthey

Clarify some things in the docs of `Global`

Follow-up to clear up some remaining confusion after rust-lang#163332

cc @Mark-Simulacrum
r? clarfonthey
Add safety comments for alloc::string

This PR serves as a following PR with rust-lang#163445 . This PR replace `// ignore-tidy-undocumented-unsafe` with concrete safety comments. Every `// ignore-tidy-undocumented-unsafe` in `alloc::string` is checked. This PR only contains a file for ease of review.
@rust-bors rust-bors Bot added the rollup A PR which is a rollup label Sep 29, 2026
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 29, 2026
@JonathanBrouwer

Copy link
Copy Markdown
Member Author

@bors r+ p=5 force

@rust-bors

rust-bors Bot commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 08aa152 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 29, 2026
@rust-bors

This comment has been minimized.

@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 29, 2026
@rust-bors

rust-bors Bot commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 2m 21s
Pushing ea6bb45 to main...

@rust-bors
rust-bors Bot merged commit ea6bb45 into rust-lang:main Sep 29, 2026
14 checks passed
@rustbot rustbot added this to the 1.101.0 milestone Sep 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing b46c90c (parent) -> ea6bb45 (this PR)

Test differences

Show 233 test diffs

Stage 1

  • [ui (polonius)] tests/ui/attributes/use-tree-in-docs.rs: [missing] -> pass (J1)
  • [ui] tests/ui/attributes/use-tree-in-docs.rs: [missing] -> pass (J2)

Stage 2

  • [ui] tests/ui/attributes/use-tree-in-docs.rs: [missing] -> pass (J0)

Additionally, 230 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard ea6bb45b74c24a026dab4187b1550e97b6985c8a --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. test-x86_64-mingw-2: 1h 41m -> 2h 49m (+66.7%)
  2. test-x86_64-gnu-stable: 1h 34m -> 2h 33m (+62.5%)
  3. test-i686-gnu-2: 1h 5m -> 1h 38m (+48.8%)
  4. test-x86_64-gnu-llvm-22-3: 1h 51m -> 1h 10m (-36.8%)
  5. test-x86_64-gnu-miri: 1h 25m -> 55m (-35.7%)
  6. dist-various-2: 40m 17s -> 54m 39s (+35.7%)
  7. dist-powerpc64-linux-gnu: 1h 36m -> 1h 2m (-35.2%)
  8. test-i686-gnu-nopt-2: 2h 25m -> 1h 34m (-34.9%)
  9. test-aarch64-apple-macos-26-2: 2h 5m -> 2h 46m (+33.0%)
  10. optional-test-x86_64-gnu-autodiff: 48m 23s -> 33m 5s (-31.6%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (ea6bb45): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
0.2% [0.2%, 0.2%] 1
Regressions ❌
(secondary)
0.3% [0.3%, 0.3%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.2% [0.2%, 0.2%] 1

Max RSS (memory usage)

Results (primary -0.2%, secondary -0.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.6% [2.6%, 2.6%] 1
Regressions ❌
(secondary)
2.4% [2.4%, 2.4%] 1
Improvements ✅
(primary)
-3.1% [-3.1%, -3.1%] 1
Improvements ✅
(secondary)
-3.0% [-3.0%, -3.0%] 1
All ❌✅ (primary) -0.2% [-3.1%, 2.6%] 2

Cycles

Results (secondary -2.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.7% [-2.7%, -2.7%] 1
All ❌✅ (primary) - - 0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 491.711s -> 489.575s (-0.43%)
Artifact size: 406.38 MiB -> 406.37 MiB (-0.00%)

@rust-bors

rust-bors Bot commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#163401 Clarify some things in the docs of Global 958387be45d9a7db903c486fb3038d54cafb112c
(link)
#163463 Add safety comments for alloc::string ed87aa9ce0957ff022f418ecbd203e0b8d849260
(link)
#163474 Fix ICE when use tree appears in docs 2c5a11efd1b32539c71ff19802aaa3306f6ec42d
(link)

parent commit: b46c90c561

In the case of a perf regression, run the following command with the SHAs of each PR you suspect might be the cause: @rust-timer triage $SHA $SHA $SHA..., or run @rust-timer triage all to benchmark all rollup members.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants