Repository navigation
Add safety comments for alloc::string - #163463
Merged
Merged
Conversation
Collaborator
|
r? @jhpratt rustbot has assigned @jhpratt. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
Member
|
The error from CI is This is probably |
yilin0518
force-pushed
the
fix_tidy_string
branch
from
September 29, 2026 05:56
e748231 to
ad22f2f
Compare
Contributor
Author
I change that line of code by mistake(by using document formatting in vscode). Now it should be no problem. |
jhpratt
reviewed
Sep 29, 2026
yilin0518
force-pushed
the
fix_tidy_string
branch
from
September 29, 2026 08:34
ad22f2f to
2ccceb0
Compare
Member
|
Thanks! @bors r+ rollup |
Contributor
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 29, 2026
Rollup merge of #163463 - yilin0518:fix_tidy_string, r=jhpratt Add safety comments for alloc::string This PR serves as a following PR with #163445 . This PR replace `// ignore-tidy-undocumented-unsafe` with concrete safety comments. Every `// ignore-tidy-undocumented-unsafe` in `alloc::string` is checked. This PR only contains a file for ease of review.
pull Bot
pushed a commit
to LeeeeeeM/miri
that referenced
this pull request
Sep 30, 2026
…uwer Rollup of 3 pull requests Successful merges: - rust-lang/rust#163401 (Clarify some things in the docs of `Global`) - rust-lang/rust#163463 (Add safety comments for alloc::string) - rust-lang/rust#163474 (Fix ICE when use tree appears in docs)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR serves as a following PR with #163445 . This PR replace
// ignore-tidy-undocumented-unsafewith concrete safety comments. Every// ignore-tidy-undocumented-unsafeinalloc::stringis checked. This PR only contains a file for ease of review.