Repository navigation
moving div_ceil() to associated items macro - #163292
Conversation
rustbot
added
S-waiting-on-review
|
Thanks for the pull request, and welcome! The Rust Project has assigned @clarfonthey (or someone else) to review your changes, you should hear from them (or someone else) within the next two weeks. Please see the contribution instructions and our LLM policy for more information. Why was this reviewer chosen?The reviewer was selected based on:
|
|
FWIW, you may be unaware that Copilot does this, but I would strongly encourage you to check your settings and ensure that automatically requesting reviews is disabled, so that we don't get them on this repo, or really any repo that might not want it. This one thankfully did not provide any outright incorrect info, but, in general they don't always help, and we prefer to do our own review. More info is in our LLM policy: https://forge.rust-lang.org/policies/llm-usage.html Will try and get to this tomorrow, just wanted to let you know about that. |
|
Actually, this headache isn't so bad, and I'm even more confused why this is the case after checking the change even though you already explained it. Thanks for the help. @bors r+ rollup |
|
⌛ Commit 980e0f0 has been tentatively approved by |
rust-bors
Bot
added
S-waiting-on-bors
Rollup of 7 pull requests Successful merges: - #160068 (Preserve explicit register names in inline asm diagnostics) - #163239 (Fix applicability level for cfg suggestion) - #163025 (make `Complex` ABI GCC-compatible on sparc) - #163076 (powerpc64: don't pass unions in FPRs on ELFv1) - #163268 ([rustdoc] Correctly check that an item is not `doc(hidden)` with `--generate-link-to-definition`) - #163288 (Tweak Layout::from_size_align_unchecked safety comment) - #163292 (moving div_ceil() to associated items macro)
Rollup merge of #163292 - Eleocraft:move-div-ceil, r=clarfonthey moving div_ceil() to associated items macro Currently the div_ceil() method of unsigned NonZero is beeing generated inside the `nonzero_integer_signedness_dependent_impls` macro. This seems odd, as this macro seems to otherwise only be used for Trait impls, whereas associated methods like div_ceil() are all in the `nonzero_integer_signedness_dependent_methods` macro. If nothing else this causes an issue in the docs, where currently all unsigned NonZero types have two documented impl blocks, one containing only div_ceil(), and the other containing the remaining associated methods and constants. This PR assumes that this is accidental. If that is not the case then maybe the explanation should be documented somewhere instead.
Currently the div_ceil() method of unsigned NonZero is beeing generated inside the
nonzero_integer_signedness_dependent_implsmacro. This seems odd, as this macro seems to otherwise only be used for Trait impls, whereas associated methods like div_ceil() are all in the
nonzero_integer_signedness_dependent_methodsmacro. If nothing else this causes an issue in the docs, where currently all unsigned NonZero types have two documented impl blocks, one containing only div_ceil(), and the other containing the remaining associated methods and constants.
This PR assumes that this is accidental. If that is not the case then maybe the explanation should be documented somewhere instead.