Repository navigation
[rustdoc] Correctly check that an item is not doc(hidden) with --generate-link-to-definition - #163268
Merged
rust-bors[bot] merged 2 commits intoSep 25, 2026
Merged
Conversation
rustbot
added
S-waiting-on-review
This comment was marked as resolved.
This comment was marked as resolved.
GuillaumeGomez
force-pushed
the
jump-to-def-hidden
branch
from
September 24, 2026 14:34
20b4b07 to
44192f7
Compare
Urgau
reviewed
Sep 24, 2026
…nts, before generating a jump to def link
GuillaumeGomez
force-pushed
the
jump-to-def-hidden
branch
from
September 24, 2026 16:19
44192f7 to
89c1934
Compare
Urgau
approved these changes
Sep 24, 2026
Member
|
@bors r+ rollup |
Contributor
|
⌛ Commit 4de84d7 has been tentatively approved by |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 25, 2026
Rollup of 7 pull requests Successful merges: - #160068 (Preserve explicit register names in inline asm diagnostics) - #163239 (Fix applicability level for cfg suggestion) - #163025 (make `Complex` ABI GCC-compatible on sparc) - #163076 (powerpc64: don't pass unions in FPRs on ELFv1) - #163268 ([rustdoc] Correctly check that an item is not `doc(hidden)` with `--generate-link-to-definition`) - #163288 (Tweak Layout::from_size_align_unchecked safety comment) - #163292 (moving div_ceil() to associated items macro)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for #162808.
The problem was that we only checked the item itself, not any of its parents. Fixed by adding a loop.
r? @Urgau