Change some `Infallible` to `!` in std by camsteffen · Pull Request #162073 · rust-lang/rust

camsteffen · 2026-08-31T16:06:18Z

I believe this desirable since we recommend ! over Infallible, so std follows its own advice. Most changes are to unstable features, but not all. Similar changes in compiler have to wait for a bootstrap update.

rustbot · 2026-08-31T16:06:24Z

r? @clarfonthey

rustbot has assigned @clarfonthey.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: libs
libs expanded to 12 candidates
Random selection from JohnTitor, Mark-Simulacrum, clarfonthey, joboet, nia-e

clarfonthey · 2026-08-31T16:11:26Z

Thank you!

@bors r+ rollup

rust-bors · 2026-08-31T16:11:29Z

📌 Commit 8e9bc25 has been approved by clarfonthey

It is now in the queue for this repository.

clarfonthey · 2026-08-31T18:21:18Z

@bors r-

(I thought that would be automatic, honestly.)

rust-bors · 2026-08-31T18:21:22Z

This pull request was unapproved.

View changes since this unapproval

camsteffen · 2026-08-31T21:34:34Z

I fixed the rustdoc test and it looks reasonable but I'm not very familiar with that.

camsteffen · 2026-08-31T22:52:14Z

(I thought that would be automatic, honestly.)

Got me curious so I found rust-lang/bors#317

clarfonthey · 2026-09-01T12:03:05Z

I fixed the rustdoc test and it looks reasonable but I'm not very familiar with that.

Mentioned it on Zulip to see if anyone has comments: #t-rustdoc > never_search test @ 💬

camsteffen · 2026-09-01T13:18:18Z

@rustbot ready

clarfonthey · 2026-09-01T13:36:29Z

@bors r+ rollup

Thank you! Got confirmation that the never_search test is indeed just checking for searches to never, and that showing up with new impls is fine.

rust-bors · 2026-09-01T13:36:32Z

📌 Commit 49736a2 has been approved by clarfonthey

It is now in the queue for this repository.

MusicalNinjaDad

Thanks - I'd just done something similar but smaller scoped :)

View changes since this review

rust-bors · 2026-09-01T13:57:34Z

⚠️ A new commit dd132214ed3e2415da4292fec21f564f4496baa5 was pushed.

This pull request was unapproved.

rustbot · 2026-09-01T13:57:36Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

camsteffen · 2026-09-01T16:09:30Z

@rustbot ready (sorry, need another Bors-R-Plus)

clarfonthey · 2026-09-01T17:45:50Z

All good! I wasn't going to unapprove for that change, but fine re-approving for it.

@bors r+

rust-bors · 2026-09-01T17:45:52Z

📌 Commit dd13221 has been approved by clarfonthey

It is now in the queue for this repository.

…nthey Change some `Infallible` to `!` in std I believe this desirable since we recommend `!` over `Infallible`, so std follows its own advice. Most changes are to unstable features, but not all. Similar changes in compiler have to wait for a bootstrap update.

MusicalNinjaDad · 2026-09-01T18:29:55Z

All good! I wasn't going to unapprove for that change, but fine re-approving for it.

@bors r+

Sorry!
I didn't want to reset approval with the suggestion. I think I hit send on the review obvious moments after the approval happened, so I didn't see it until too late.

camsteffen · 2026-09-01T18:31:56Z

No worries

clarfonthey · 2026-09-01T19:08:02Z

It's all good! It worked out in the end.

…uwer Rollup of 11 pull requests Successful merges: - #151618 (rustdoc: add `--print` option) - #161287 (Update `icu_list` dependency to 2.3) - #161767 (change DEFAULT_STACK_SIZE to be 32MB on s390x) - #161968 (Diverse offload fixes) - #161971 (Remove -Zsaturating-float-casts flag) - #162071 (Fix ICE of getting item name from RPITIT) - #161209 (Rework `next_power_of_two` to always be `1 << …`) - #162073 (Change some `Infallible` to `!` in std) - #162086 (Remove `gate_check` from `AttributeStability::Unstable`) - #162102 (`alloc` crate: shrink undocumented `unsafe` blocks) - #162110 (make it clear that Range cannot represent arbitrary ranges)

Rollup merge of #162073 - camsteffen:lib-eat-never, r=clarfonthey Change some `Infallible` to `!` in std I believe this desirable since we recommend `!` over `Infallible`, so std follows its own advice. Most changes are to unstable features, but not all. Similar changes in compiler have to wait for a bootstrap update.

rustbot assigned clarfonthey Aug 31, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 31, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 31, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 31, 2026

rust-bors Bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 31, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 1, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 1, 2026

MusicalNinjaDad reviewed Sep 1, 2026

View reviewed changes

Comment thread library/alloc/src/bstr.rs Outdated

Dogfood never type in std

dd13221

camsteffen force-pushed the lib-eat-never branch from 49736a2 to dd13221 Compare September 1, 2026 13:57

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 1, 2026

rustbot added the A-rustdoc-js Area: Rustdoc's JS front-end label Sep 1, 2026

rustbot added A-rustdoc-search Area: Rustdoc's search feature T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Sep 1, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 1, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 1, 2026

JonathanBrouwer mentioned this pull request Sep 1, 2026

Rollup of 11 pull requests #162139

Closed

JonathanBrouwer mentioned this pull request Sep 1, 2026

Rollup of 11 pull requests #162148

Merged

rust-bors Bot merged commit e2897d7 into rust-lang:main Sep 1, 2026
13 checks passed

rustbot added this to the 1.100.0 milestone Sep 1, 2026

MusicalNinjaDad mentioned this pull request Sep 2, 2026

Stabilize the Try trait rust-lang/goals#654

Open

8 tasks

Uh oh!

Uh oh!

Conversation

camsteffen commented Aug 31, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Aug 31, 2026

Uh oh!

clarfonthey commented Aug 31, 2026

Uh oh!

rust-bors Bot commented Aug 31, 2026

Uh oh!

This comment has been minimized.

clarfonthey commented Aug 31, 2026

Uh oh!

rust-bors Bot commented Aug 31, 2026

Uh oh!

camsteffen commented Aug 31, 2026

Uh oh!

camsteffen commented Aug 31, 2026

Uh oh!

clarfonthey commented Sep 1, 2026

Uh oh!

camsteffen commented Sep 1, 2026

Uh oh!

clarfonthey commented Sep 1, 2026

Uh oh!

rust-bors Bot commented Sep 1, 2026

Uh oh!

MusicalNinjaDad left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rust-bors Bot commented Sep 1, 2026

Uh oh!

rustbot commented Sep 1, 2026

Uh oh!

camsteffen commented Sep 1, 2026

Uh oh!

clarfonthey commented Sep 1, 2026

Uh oh!

rust-bors Bot commented Sep 1, 2026

Uh oh!

MusicalNinjaDad commented Sep 1, 2026

Uh oh!

camsteffen commented Sep 1, 2026

Uh oh!

clarfonthey commented Sep 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

camsteffen commented Aug 31, 2026 •

edited by rustbot

Loading

MusicalNinjaDad left a comment •

edited by rustbot

Loading