Fix ICE of getting item name from RPITIT - #162071
Merged
rust-bors[bot] merged 1 commit intoSep 1, 2026
Merged
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @BoxyUwU rustbot has assigned @BoxyUwU. Use Why was this reviewer chosen?The reviewer was selected based on:
|
BoxyUwU
reviewed
Aug 31, 2026
| match (alias1.kind, alias2.kind) { | ||
| (ty::Projection { def_id: def_id1 }, ty::Projection { def_id: def_id2 }) => { | ||
| (ty::Projection { def_id: def_id1 }, ty::Projection { def_id: def_id2 }) | ||
| if !self.tcx.is_impl_trait_in_trait(def_id1) |
Member
There was a problem hiding this comment.
can you add a comment about why this codepath doesn't work for RPITITs
chenyukang
force-pushed
the
yukang-fix-161915-rpitit-mismatch-ice
branch
from
August 31, 2026 14:59
ab1eb7f to
2da3240
Compare
theemathas
added
the
beta-nominated
Contributor
|
@bors r+ |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
estebank
reviewed
Sep 1, 2026
Comment on lines
+9
to
+10
| LL | | true => T::create(), | ||
| | | ----------- this is found to be of type `impl Form` |
Contributor
There was a problem hiding this comment.
(Thinking out loud) This is a tiny papercut, where we use the name of the opaque type that <T as Parameter>::create() returns, which happens to coincide with the return type of forms_at_phase, obscuring what's happening slightly.
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 1, 2026
…uwer Rollup of 11 pull requests Successful merges: - #151618 (rustdoc: add `--print` option) - #161287 (Update `icu_list` dependency to 2.3) - #161767 (change DEFAULT_STACK_SIZE to be 32MB on s390x) - #161968 (Diverse offload fixes) - #161971 (Remove -Zsaturating-float-casts flag) - #162071 (Fix ICE of getting item name from RPITIT) - #161209 (Rework `next_power_of_two` to always be `1 << …`) - #162073 (Change some `Infallible` to `!` in std) - #162086 (Remove `gate_check` from `AttributeStability::Unstable`) - #162102 (`alloc` crate: shrink undocumented `unsafe` blocks) - #162110 (make it clear that Range cannot represent arbitrary ranges)
Collaborator
|
beta backport approved as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle. Backport labels are handled by them. |
rustbot
added
the
beta-accepted
cuviper
removed
the
beta-nominated
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 3, 2026
[beta] backports - Avoid arming the Windows TLS destructor guard in fibers #161451 - (partial) stdarch subtree update #161558 - Check to ensure we're running against the correct LLVM version #161788 - Make the LLVM version mismatch ICE a fatal error #162034 - Revert "Add `rustc_test_entrypoint_marker`" #161931 - Fix ICE of getting name from RPITIT #162071 - Update LLVM submodule #162133 - Revert "Implement Debug for C-like enums with a concatenated string" #162164 r? me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #161915
RPITIT projections use anonymous associated type and have no item name.