remove `_{style}` recovery for diagnostic structs by mejrs · Pull Request #162055 · rust-lang/rust

mejrs · 2026-08-31T11:14:37Z

Followup to #103575

Also documents the style = "..." option.

rustbot · 2026-08-31T11:14:41Z

rustc-dev-guide is developed in its own repository. If possible, consider making this change to rust-lang/rustc-dev-guide instead.

cc @BoxyUwU, @tshepang

rustc_macros::diagnostics was changed

cc @TaKO8Ki, @JonathanBrouwer

rustbot · 2026-08-31T11:14:44Z

r? @folkertdev

rustbot has assigned @folkertdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 75 candidates
Random selection from 17 candidates

JonathanBrouwer · 2026-08-31T11:45:43Z

r? me

JonathanBrouwer

@bors r+ rollup

View changes since this review

rust-bors · 2026-08-31T19:36:31Z

📌 Commit 1483f9b has been approved by JonathanBrouwer

It is now in the queue for this repository.

remove `_{style}` recovery for diagnostic structs Followup to rust-lang#103575 Also documents the `style = "..."` option.

…uwer Rollup of 12 pull requests Successful merges: - #162045 (`rust-analyzer` subtree update) - #162077 (compiler-builtins subtree update) - #137720 (support `#[target_feature(enable = ...)]` on `#[naked]` functions) - #160534 (stabilize smart pointer map functions) - #160551 (mir_build: Clearly distinguish or/refutable/irrefutable patterns during match lowering) - #161929 (explicitly track inherent const generic args kind) - #162063 (Switch dist-aarch64-linux to EC2 and update dist-x86_64-linux) - #161937 (A series of Polonius Alpha refactors) - #162014 (Move more `rustdoc-html` tests using `--test` into the right folder) - #162051 (`rustc_feature` cleanups) - #162055 (remove `_{style}` recovery for diagnostic structs) - #162075 (Move track_caller on closures gating to attribute parsing)

remove `_{style}` recovery for diagnostic structs Followup to rust-lang#103575 Also documents the `style = "..."` option.

…uwer Rollup of 16 pull requests Successful merges: - #137720 (support `#[target_feature(enable = ...)]` on `#[naked]` functions) - #160534 (stabilize smart pointer map functions) - #160551 (mir_build: Clearly distinguish or/refutable/irrefutable patterns during match lowering) - #160989 (Make sin, cos, exp, exp2, log, log2, log10 generic) - #161861 (mir_build: Clarify parts of if-condition lowering) - #161929 (explicitly track inherent const generic args kind) - #162040 (bootstrap: stage0 to cbae9b4) - #162063 (Switch dist-aarch64-linux to EC2 and update dist-x86_64-linux) - #161353 (Add test for parallel compiler reproducible build) - #161937 (A series of Polonius Alpha refactors) - #162051 (`rustc_feature` cleanups) - #162055 (remove `_{style}` recovery for diagnostic structs) - #162075 (Move track_caller on closures gating to attribute parsing) - #162079 (std: implement `File::fsync` for Hermit) - #162097 (Deduplicate `InstrumentFnAttr`) - #162115 (fix typo in feature documentation)

Rollup merge of #162055 - mejrs:_style, r=JonathanBrouwer remove `_{style}` recovery for diagnostic structs Followup to #103575 Also documents the `style = "..."` option.

rust-timer · 2026-09-01T19:27:47Z

Finished benchmarking commit (ea939b0): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (secondary -1.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.9%	[-2.4%, -0.8%]	3
All ❌✅ (primary)	-	-	0

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: missing data
Artifact size: 400.59 MiB -> 400.58 MiB (-0.00%)

…uwer Rollup of 16 pull requests Successful merges: - rust-lang/rust#137720 (support `#[target_feature(enable = ...)]` on `#[naked]` functions) - rust-lang/rust#160534 (stabilize smart pointer map functions) - rust-lang/rust#160551 (mir_build: Clearly distinguish or/refutable/irrefutable patterns during match lowering) - rust-lang/rust#160989 (Make sin, cos, exp, exp2, log, log2, log10 generic) - rust-lang/rust#161861 (mir_build: Clarify parts of if-condition lowering) - rust-lang/rust#161929 (explicitly track inherent const generic args kind) - rust-lang/rust#162040 (bootstrap: stage0 to cbae9b4cae2b108f6a3d18cfe6075714bb739463) - rust-lang/rust#162063 (Switch dist-aarch64-linux to EC2 and update dist-x86_64-linux) - rust-lang/rust#161353 (Add test for parallel compiler reproducible build) - rust-lang/rust#161937 (A series of Polonius Alpha refactors) - rust-lang/rust#162051 (`rustc_feature` cleanups) - rust-lang/rust#162055 (remove `_{style}` recovery for diagnostic structs) - rust-lang/rust#162075 (Move track_caller on closures gating to attribute parsing) - rust-lang/rust#162079 (std: implement `File::fsync` for Hermit) - rust-lang/rust#162097 (Deduplicate `InstrumentFnAttr`) - rust-lang/rust#162115 (fix typo in feature documentation)

rustbot assigned folkertdev Aug 31, 2026

rustbot assigned JonathanBrouwer and unassigned folkertdev Aug 31, 2026

This comment has been minimized.

Sign in to view

mejrs force-pushed the _style branch from 261893b to 5d09e7f Compare August 31, 2026 12:44

remove _{style} recovery for diagnostic structs

1483f9b

mejrs force-pushed the _style branch from 5d09e7f to 1483f9b Compare August 31, 2026 14:03

JonathanBrouwer approved these changes Aug 31, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 31, 2026

JonathanBrouwer mentioned this pull request Aug 31, 2026

Rollup of 10 pull requests #162087

Closed

GuillaumeGomez mentioned this pull request Aug 31, 2026

Rollup of 11 pull requests #162088

Closed

JonathanBrouwer mentioned this pull request Aug 31, 2026

Rollup of 12 pull requests #162089

Closed

jhpratt added a commit to jhpratt/rust that referenced this pull request Sep 1, 2026

Rollup merge of rust-lang#162055 - mejrs:_style, r=JonathanBrouwer

4b32f7f

remove `_{style}` recovery for diagnostic structs Followup to rust-lang#103575 Also documents the `style = "..."` option.

jhpratt mentioned this pull request Sep 1, 2026

Rollup of 12 pull requests #162100

Closed

jhpratt added a commit to jhpratt/rust that referenced this pull request Sep 1, 2026

Rollup merge of rust-lang#162055 - mejrs:_style, r=JonathanBrouwer

f7e3df1

remove `_{style}` recovery for diagnostic structs Followup to rust-lang#103575 Also documents the `style = "..."` option.

jhpratt mentioned this pull request Sep 1, 2026

Rollup of 11 pull requests #162101

Closed

JonathanBrouwer mentioned this pull request Sep 1, 2026

Rollup of 16 pull requests #162117

Merged

rust-bors Bot merged commit 6d0d954 into rust-lang:main Sep 1, 2026
13 checks passed

rustbot added this to the 1.100.0 milestone Sep 1, 2026

Navigation Menu

Uh oh!

Uh oh!

remove `_{style}` recovery for diagnostic structs - #162055

remove `_{style}` recovery for diagnostic structs#162055
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
mejrs:_style

mejrs commented Aug 31, 2026 •

edited

Loading

Uh oh!

rustbot commented Aug 31, 2026

Uh oh!

rustbot commented Aug 31, 2026

Uh oh!

JonathanBrouwer commented Aug 31, 2026

Uh oh!

This comment has been minimized.

JonathanBrouwer left a comment •

edited by rustbot

Loading

Uh oh!

rust-bors Bot commented Aug 31, 2026

Uh oh!

Uh oh!

rust-timer commented Sep 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Uh oh!

Conversation

mejrs commented Aug 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Aug 31, 2026

Uh oh!

rustbot commented Aug 31, 2026

Uh oh!

JonathanBrouwer commented Aug 31, 2026

Uh oh!

This comment has been minimized.

JonathanBrouwer left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors Bot commented Aug 31, 2026

Uh oh!

Uh oh!

rust-timer commented Sep 1, 2026

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mejrs commented Aug 31, 2026 •

edited

Loading

JonathanBrouwer left a comment •

edited by rustbot

Loading