compiler: Allow safestack to be togglable via #[sanitize(safestack = "...")] - #161888
Conversation
|
Some changes occurred in tests/codegen-llvm/sanitizer cc @rcvalle Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
A-attributes
rustbot
added
the
T-compiler
|
r? @khyperia rustbot has assigned @khyperia. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
|
Could you maybe add a PR description explaining what's going on here, what this is used for, linking to relevant tracking issues and whatnot? I came in with zero context and had to do some digging to figure out what's going on here ✨ Anyway, while I'm 95% confident this is totally fine to r+, I'm not 100% since this isn't my area of expertise. Considering adwin suggested this in #159873 , gonna pass the review to them: r? @adwinwhite |
Added description |
|
I guess it's fine to merge. The @bors r+ rollup |
rust-bors
Bot
added
S-waiting-on-bors
Rollup of 17 pull requests Successful merges: - #161945 (std: optimise IO error formatting) - #160594 (attach global target features to module-level assembly) - #161577 (implement [u8]::split_ascii_whitespace) - #161858 (fix ICE in generic_const_parameter_types with inherents) - #161377 ([bootstrap] Don't reverse the order of dylib search path entries) - #161804 (Document PartialOrd behavior for Option<T> where T: PartialOrd) - #161865 (loongarch: support passing `u128`/`i128` to inline assembly) - #161877 (Do not load macro metadata for local definitions in rustdoc) - #161880 (fix rustc_lint_defs doctest issues) - #161883 (better deal with internal features being injected into doctests) - #161887 (std: uefi: fix File::seek returning the EOF sentinel) - #161888 (compiler: Allow safestack to be togglable via #[sanitize(safestack = "...")]) - #161897 (Reject contract attributes without arguments) - #161910 (Add rustdoc-html regression test for generated macro) - #161914 (Retroactively add relnotes for `bool::{ok_or,ok_or_else}` (1.98.0)) - #161924 (Windows: document that `normalize_lexically` converts `/` to `\`) - #161927 (Change `rustc_middle/src/hooks/mod.rs` to `hooks.rs`)
Rollup merge of #161888 - PiJoules:sanitize-safestack-togglable, r=adwinwhite compiler: Allow safestack to be togglable via #[sanitize(safestack = "...")] Since safestack is a sanitizer, it should be possible to allow enabling/disabling it on functions like we do with the other sanitizers. It's likely that when adding the `#[sanitize(...)]` support for the other ones that safestack was just missed, so this makes safestack follow suite. It was also suggested in #159873 that we just disable safestack this way for a specific test where we should check stack protector instrumentation.
5 participants
Since safestack is a sanitizer, it should be possible to allow enabling/disabling it on functions like we do with the other sanitizers. It's likely that when adding the
#[sanitize(...)]support for the other ones that safestack was just missed, so this makes safestack follow suite. It was also suggested in #159873 that we just disable safestack this way for a specific test where we should check stack protector instrumentation.