Document PartialOrd behavior for Option<T> where T: PartialOrd by zepredos · Pull Request #161804 · rust-lang/rust

zepredos · 2026-08-26T09:45:08Z

Fixes #161746
This is my first time contributing to Rust and all feedback is welcome.
I ran these after making changes.
./x test library/core --stage 1
./x.py setup
./x test tidy --bless

rustbot · 2026-08-26T09:45:14Z

Thanks for the pull request, and welcome! The Rust Project has assigned @nia-e (or someone else) to review your changes, you should hear from them (or someone else) within the next two weeks.

Please see the contribution instructions and our LLM policy for more information.

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: libs
libs expanded to 12 candidates
Random selection from JohnTitor, Mark-Simulacrum, clarfonthey, nia-e

zepredos · 2026-08-26T12:19:48Z

@rustbot label +A-docs

Oakchris1955 · 2026-08-27T12:21:38Z

This is my personal opinion, but I believe in order to prevent unnecessary duplication, perhaps it would be more simple to just link to the relevant section of the docs instead of duplicating them word-by-word.

zepredos · 2026-08-27T14:06:38Z

Sure, I'll make the changes and push them.

nia-e · 2026-08-28T06:53:11Z

If we're adding docs here, it's worth mentioning that None always compares less than any Some; once that's done we can merge this. Thanks ^^

@rustbot author

rustbot · 2026-08-28T06:53:15Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

zepredos · 2026-08-28T15:40:51Z

Thanks for the review @nia-e ! Sure, let me add and push it real quick :D

nia-e · 2026-08-28T16:09:39Z

lgtm ^^

@bors r+ rollup

rust-bors · 2026-08-28T16:09:42Z

📌 Commit d3b2959 has been approved by nia-e

It is now in the queue for this repository.

nia-e · 2026-08-28T16:18:12Z

(also, as a friendly tip to you as the author: don't worry about listing tests ran in the PR description unless it's something really weird; we have pretty thorough CI and also it can get flagged as LLM-speak. nothing wrong with it ofc, just letting you know ^^)

zepredos · 2026-08-28T16:21:32Z

I see, that's a useful tip. Thank you so much!! I'll keep that in mind for future contributions :)

…, r=nia-e Document PartialOrd behavior for Option<T> where T: PartialOrd Fixes [rust-lang#161746]("rust-lang#161746") This is my first time contributing to Rust and all feedback is welcome. I ran these after making changes. `./x test library/core --stage 1` `./x.py setup` `./x test tidy --bless`

…uwer Rollup of 15 pull requests Successful merges: - #160170 (Refactored docs for `std::fs::set_permissions_nofollow` + fix BSD-based systems to use fchmodat with AT_SYMLINK_NOFOLLOW flag) - #160594 (attach global target features to module-level assembly) - #161858 (fix ICE in generic_const_parameter_types with inherents) - #161353 (Add test for parallel compiler reproducible build) - #161377 ([bootstrap] Don't reverse the order of dylib search path entries) - #161804 (Document PartialOrd behavior for Option<T> where T: PartialOrd) - #161865 (loongarch: support passing `u128`/`i128` to inline assembly) - #161877 (Do not load macro metadata for local definitions in rustdoc) - #161880 (fix rustc_lint_defs doctest issues) - #161883 (better deal with internal features being injected into doctests) - #161887 (std: uefi: fix File::seek returning the EOF sentinel) - #161897 (Reject contract attributes without arguments) - #161909 (Report the configured Polonius default in -Z help) - #161910 (Add rustdoc-html regression test for generated macro) - #161914 (Retroactively add relnotes for `bool::{ok_or,ok_or_else}` (1.98.0))

…, r=nia-e Document PartialOrd behavior for Option<T> where T: PartialOrd Fixes [rust-lang#161746]("rust-lang#161746") This is my first time contributing to Rust and all feedback is welcome. I ran these after making changes. `./x test library/core --stage 1` `./x.py setup` `./x test tidy --bless`

…uwer Rollup of 16 pull requests Successful merges: - #160170 (Refactored docs for `std::fs::set_permissions_nofollow` + fix BSD-based systems to use fchmodat with AT_SYMLINK_NOFOLLOW flag) - #161945 (std: optimise IO error formatting) - #160594 (attach global target features to module-level assembly) - #161577 (implement [u8]::split_ascii_whitespace) - #161858 (fix ICE in generic_const_parameter_types with inherents) - #161377 ([bootstrap] Don't reverse the order of dylib search path entries) - #161804 (Document PartialOrd behavior for Option<T> where T: PartialOrd) - #161865 (loongarch: support passing `u128`/`i128` to inline assembly) - #161877 (Do not load macro metadata for local definitions in rustdoc) - #161880 (fix rustc_lint_defs doctest issues) - #161883 (better deal with internal features being injected into doctests) - #161887 (std: uefi: fix File::seek returning the EOF sentinel) - #161897 (Reject contract attributes without arguments) - #161909 (Report the configured Polonius default in -Z help) - #161910 (Add rustdoc-html regression test for generated macro) - #161914 (Retroactively add relnotes for `bool::{ok_or,ok_or_else}` (1.98.0))

…, r=nia-e Document PartialOrd behavior for Option<T> where T: PartialOrd Fixes [rust-lang#161746]("rust-lang#161746") This is my first time contributing to Rust and all feedback is welcome. I ran these after making changes. `./x test library/core --stage 1` `./x.py setup` `./x test tidy --bless`

…uwer Rollup of 16 pull requests Successful merges: - #161945 (std: optimise IO error formatting) - #160594 (attach global target features to module-level assembly) - #161577 (implement [u8]::split_ascii_whitespace) - #161858 (fix ICE in generic_const_parameter_types with inherents) - #161377 ([bootstrap] Don't reverse the order of dylib search path entries) - #161702 (Use `drop_guard` in some places in {core,alloc,std}) - #161804 (Document PartialOrd behavior for Option<T> where T: PartialOrd) - #161865 (loongarch: support passing `u128`/`i128` to inline assembly) - #161877 (Do not load macro metadata for local definitions in rustdoc) - #161880 (fix rustc_lint_defs doctest issues) - #161883 (better deal with internal features being injected into doctests) - #161887 (std: uefi: fix File::seek returning the EOF sentinel) - #161897 (Reject contract attributes without arguments) - #161909 (Report the configured Polonius default in -Z help) - #161910 (Add rustdoc-html regression test for generated macro) - #161914 (Retroactively add relnotes for `bool::{ok_or,ok_or_else}` (1.98.0))

…, r=nia-e Document PartialOrd behavior for Option<T> where T: PartialOrd Fixes [rust-lang#161746]("rust-lang#161746") This is my first time contributing to Rust and all feedback is welcome. I ran these after making changes. `./x test library/core --stage 1` `./x.py setup` `./x test tidy --bless`

Rollup of 17 pull requests Successful merges: - #161945 (std: optimise IO error formatting) - #160594 (attach global target features to module-level assembly) - #161577 (implement [u8]::split_ascii_whitespace) - #161858 (fix ICE in generic_const_parameter_types with inherents) - #161377 ([bootstrap] Don't reverse the order of dylib search path entries) - #161804 (Document PartialOrd behavior for Option<T> where T: PartialOrd) - #161865 (loongarch: support passing `u128`/`i128` to inline assembly) - #161877 (Do not load macro metadata for local definitions in rustdoc) - #161880 (fix rustc_lint_defs doctest issues) - #161883 (better deal with internal features being injected into doctests) - #161887 (std: uefi: fix File::seek returning the EOF sentinel) - #161897 (Reject contract attributes without arguments) - #161909 (Report the configured Polonius default in -Z help) - #161910 (Add rustdoc-html regression test for generated macro) - #161914 (Retroactively add relnotes for `bool::{ok_or,ok_or_else}` (1.98.0)) - #161924 (Windows: document that `normalize_lexically` converts `/` to `\`) - #161927 (Change `rustc_middle/src/hooks/mod.rs` to `hooks.rs`)

Rollup of 17 pull requests Successful merges: - #161945 (std: optimise IO error formatting) - #160594 (attach global target features to module-level assembly) - #161577 (implement [u8]::split_ascii_whitespace) - #161858 (fix ICE in generic_const_parameter_types with inherents) - #161377 ([bootstrap] Don't reverse the order of dylib search path entries) - #161804 (Document PartialOrd behavior for Option<T> where T: PartialOrd) - #161865 (loongarch: support passing `u128`/`i128` to inline assembly) - #161877 (Do not load macro metadata for local definitions in rustdoc) - #161880 (fix rustc_lint_defs doctest issues) - #161883 (better deal with internal features being injected into doctests) - #161887 (std: uefi: fix File::seek returning the EOF sentinel) - #161888 (compiler: Allow safestack to be togglable via #[sanitize(safestack = "...")]) - #161897 (Reject contract attributes without arguments) - #161910 (Add rustdoc-html regression test for generated macro) - #161914 (Retroactively add relnotes for `bool::{ok_or,ok_or_else}` (1.98.0)) - #161924 (Windows: document that `normalize_lexically` converts `/` to `\`) - #161927 (Change `rustc_middle/src/hooks/mod.rs` to `hooks.rs`)

Rollup merge of #161804 - zepredos:doc-option-partialord-fix, r=nia-e Document PartialOrd behavior for Option<T> where T: PartialOrd Fixes [#161746]("#161746") This is my first time contributing to Rust and all feedback is welcome. I ran these after making changes. `./x test library/core --stage 1` `./x.py setup` `./x test tidy --bless`

Document PartialOrd behavior for Option<T> where T: PartialOrd

8ceed4d

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 26, 2026

rustbot assigned nia-e Aug 26, 2026

This comment has been minimized.

Sign in to view

Formatting changes for HTML tag errors

3fec803

rustbot added the A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools label Aug 26, 2026

Change the doc comments to link to the relevant doc section

97fe424

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 28, 2026

Clarify None and Some comparisons in docs

d3b2959

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 28, 2026

JonathanBrouwer mentioned this pull request Aug 28, 2026

Rollup of 15 pull requests #161942

Closed

JonathanBrouwer mentioned this pull request Aug 28, 2026

Rollup of 16 pull requests #161949

Closed

JonathanBrouwer mentioned this pull request Aug 28, 2026

Rollup of 16 pull requests #161952

Closed

Zalathar mentioned this pull request Aug 29, 2026

Rollup of 17 pull requests #161955

Closed

jhpratt mentioned this pull request Aug 29, 2026

Rollup of 17 pull requests #161959

Merged

rust-bors Bot merged commit 631e6c5 into rust-lang:main Aug 29, 2026
13 checks passed

rustbot added this to the 1.100.0 milestone Aug 29, 2026

Navigation Menu

Uh oh!

Uh oh!

Document PartialOrd behavior for Option<T> where T: PartialOrd - #161804

Document PartialOrd behavior for Option<T> where T: PartialOrd#161804
rust-bors[bot] merged 4 commits into
rust-lang:mainfrom
zepredos:doc-option-partialord-fix

zepredos commented Aug 26, 2026

Uh oh!

rustbot commented Aug 26, 2026

Uh oh!

This comment has been minimized.

zepredos commented Aug 26, 2026

Uh oh!

Oakchris1955 commented Aug 27, 2026

Uh oh!

zepredos commented Aug 27, 2026

Uh oh!

nia-e commented Aug 28, 2026

Uh oh!

rustbot commented Aug 28, 2026

Uh oh!

zepredos commented Aug 28, 2026

Uh oh!

nia-e commented Aug 28, 2026

Uh oh!

rust-bors Bot commented Aug 28, 2026

Uh oh!

nia-e commented Aug 28, 2026

Uh oh!

zepredos commented Aug 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Uh oh!

Conversation

zepredos commented Aug 26, 2026

Uh oh!

rustbot commented Aug 26, 2026

Uh oh!

This comment has been minimized.

zepredos commented Aug 26, 2026

Uh oh!

Oakchris1955 commented Aug 27, 2026

Uh oh!

zepredos commented Aug 27, 2026

Uh oh!

nia-e commented Aug 28, 2026

Uh oh!

rustbot commented Aug 28, 2026

Uh oh!

zepredos commented Aug 28, 2026

Uh oh!

nia-e commented Aug 28, 2026

Uh oh!

rust-bors Bot commented Aug 28, 2026

Uh oh!

nia-e commented Aug 28, 2026

Uh oh!

zepredos commented Aug 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants