Skip to content

fix deprecated rustc_hir::attrs imports - #17714

Merged
Jarcho merged 1 commit into
rust-lang:masterfrom
mejrs:rustc_attr_ir_imports
Sep 11, 2026
Merged

Jarcho merged 1 commit into
rust-lang:masterfrom
mejrs:rustc_attr_ir_imports

Conversation

@mejrs

@mejrs mejrs commented Sep 9, 2026 •

Copy link
Copy Markdown
Member

This PR changes all rustc_hir::attrs imports to use rustc_attr_ir. This was recently split off into its own crate, and the re-export will be removed at some point. I figured it'd be best to land this in-tree.

changelog: none

@rustbot

rustbot commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in clippy_lints/src/doc

cc @notriddle

@rustbot

rustbot commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request. A reviewer will take a look after it receives 2 community reviews.

In the meantime, we would highly appreciate if you could try to review any of PRs waiting on community reviews.

@rustbot rustbot added S-waiting-on-community-reviews Status: This is awaiting for positive reviews from the community before a maintainer is assigned. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Sep 9, 2026

@notriddle notriddle left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Community review: most of this change seems fine. Just one minor nit about find_attr.

View changes since this review

Comment thread clippy_lints/src/attrs/repr_attributes.rs Outdated

@CommanderStorm CommanderStorm left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

Please make sure to add changelog: none to your description to make CI green

View changes since this review

@mejrs
mejrs force-pushed the rustc_attr_ir_imports branch from 268bbc4 to 4920e58 Compare September 10, 2026 11:31
@rustbot rustbot removed the S-waiting-on-community-reviews Status: This is awaiting for positive reviews from the community before a maintainer is assigned. label Sep 10, 2026
@rustbot

rustbot commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

r? @Jarcho

rustbot has assigned @Jarcho for the project review.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: 9 candidates
  • 9 candidates expanded to 9 candidates
  • Random selection from 6 candidates

@Jarcho Jarcho left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I'm going to pretend I read all of that.

@rustbot merge

View changes since this review

jhpratt added a commit to jhpratt/rust that referenced this pull request Sep 23, 2026
Update deprecated rustc_hir imports 2

Followup to rust-lang#160336, see also rust-lang#163170 and rust-lang/rust-clippy/pull/17714

There is one more PR after this, they're split up to hopefully not be too conflict-y.
rust-bors Bot pushed a commit to rust-lang/rust that referenced this pull request Sep 23, 2026
Rollup merge of #163207 - mejrs:hir_imports2, r=BoxyUwU

Update deprecated rustc_hir imports 2

Followup to #160336, see also #163170 and rust-lang/rust-clippy/pull/17714

There is one more PR after this, they're split up to hopefully not be too conflict-y.
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Sep 27, 2026
Remove rustc_hir's attribute re-exports

Followup to rust-lang#160336, see also rust-lang#163170, rust-lang#163207 and rust-lang/rust-clippy/pull/17714

Very minor touchups here and there, nothing involving code changes.

r? @JonathanBrouwer
rust-bors Bot pushed a commit to rust-lang/rust that referenced this pull request Sep 27, 2026
Rollup merge of #163250 - mejrs:hir_imports3, r=JonathanBrouwer

Remove rustc_hir's attribute re-exports

Followup to #160336, see also #163170, #163207 and rust-lang/rust-clippy/pull/17714

Very minor touchups here and there, nothing involving code changes.

r? @JonathanBrouwer
bjorn3 pushed a commit to rust-lang/rustc_codegen_cranelift that referenced this pull request Sep 28, 2026
Remove rustc_hir's attribute re-exports

Followup to rust-lang/rust#160336, see also rust-lang/rust#163170, rust-lang/rust#163207 and rust-lang/rust-clippy/pull/17714

Very minor touchups here and there, nothing involving code changes.

r? @JonathanBrouwer
pull Bot pushed a commit to xtqqczze/rust-lang-miri that referenced this pull request Sep 28, 2026
Remove rustc_hir's attribute re-exports

Followup to rust-lang/rust#160336, see also rust-lang/rust#163170, rust-lang/rust#163207 and rust-lang/rust-clippy/pull/17714

Very minor touchups here and there, nothing involving code changes.

r? @JonathanBrouwer
GuillaumeGomez pushed a commit to GuillaumeGomez/rustc_codegen_gcc that referenced this pull request Sep 29, 2026
Remove rustc_hir's attribute re-exports

Followup to rust-lang/rust#160336, see also rust-lang/rust#163170, rust-lang/rust#163207 and rust-lang/rust-clippy/pull/17714

Very minor touchups here and there, nothing involving code changes.

r? @JonathanBrouwer
flip1995 pushed a commit to flip1995/rust that referenced this pull request Oct 1, 2026
Remove rustc_hir's attribute re-exports

Followup to rust-lang#160336, see also rust-lang#163170, rust-lang#163207 and rust-lang/rust-clippy/pull/17714

Very minor touchups here and there, nothing involving code changes.

r? @JonathanBrouwer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants