Repository navigation
fix: missing_docs_in_private_items unfulfilling #[expect] in test mode - #16938
Kokoro2336 wants to merge 1 commit into
Conversation
rustbot
added
the
S-waiting-on-review
|
r? @llogiq rustbot has assigned @llogiq. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
r? @blyxyas |
| fn is_missing_docs(&self, cx: &LateContext<'_>, def_id: LocalDefId, hir_id: HirId) -> bool { | ||
| if cx.tcx.sess.opts.test { | ||
| // Ignore every item in a test module or a #[test] annotated function | ||
| if is_in_test(cx.tcx, hir_id) || is_cfg_test(cx.tcx, hir_id) || is_test_function(cx.tcx, def_id) { |
There was a problem hiding this comment.
We should maintain the original option check.
| if is_in_test(cx.tcx, hir_id) || is_cfg_test(cx.tcx, hir_id) || is_test_function(cx.tcx, def_id) { | |
| if cx.tcx.sess.opts.test || is_in_test(cx.tcx, hir_id) || is_cfg_test(cx.tcx, hir_id) || is_test_function(cx.tcx, def_id) { |
There was a problem hiding this comment.
@blyxyas But I think a non-test item should also be linted even if there's a opts.test flag.
rustbot
added
S-waiting-on-author
|
Reminder, once the PR becomes ready for a review, use |
fix(missing-doc): filter logic. test: supply test mode uitest.
7369eeb to
314cfbe
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
Hmm seems that test are falling... |
|
Ping @Kokoro2336 🏓 , could you fix CI? |
|
☔ The latest upstream changes (possibly #17714) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@Kokoro2336, I'm going to close this PR as stale because it seems you've been inactive. If you ever come back, please re-open this PR or open a new one. |
changelog: fix [
missing_docs_in_private_items]: unfulfilling#[expect]in test modeFixes #16934