Skip to content

Fixed stale comment about fingerprint checking method - #17450

Merged
weihanglo merged 1 commit into
rust-lang:masterfrom
ranger-ross:fix-up-doc
Sep 7, 2026
Merged

weihanglo merged 1 commit into
rust-lang:masterfrom
ranger-ross:fix-up-doc

Conversation

@ranger-ross

Copy link
Copy Markdown
Member

What does this PR try to resolve?

I was reading the fingerprint logic docs (yet again) and noticed that the doc comment didn't seems to match the code.
Seem this doc comment got left behind in #17382.

Went ahead and updated to match the updated implementation.

How to test and review this PR?

just a comment

r? @epage

@rustbot rustbot added A-rebuild-detection Area: rebuild detection and fingerprinting S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 7, 2026
@weihanglo
weihanglo enabled auto-merge September 7, 2026 14:37
@weihanglo
weihanglo added this pull request to the merge queue Sep 7, 2026
Merged via the queue into rust-lang:master with commit 42eee92 Sep 7, 2026
28 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 7, 2026
rust-bors Bot pushed a commit to rust-lang/rust that referenced this pull request Sep 12, 2026
Update cargo submodule

6 commits in 3c0b534756e166d12eb9fd2e1abfe5b42ac6101e..7941be6fb416b4cd9666aef7b858dfea25587a8c
2026-09-04 17:03:10 +0000 to 2026-09-11 20:47:37 +0000
- fix(install): use packaged lockfile by default (rust-lang/cargo#17388)
- test: add more comprehensive workspace feature unification tests (rust-lang/cargo#17466)
- chore(deps): update crossbeam-epoch to 0.9.21 (rust-lang/cargo#17427)
- Fixed stale comment about fingerprint checking method (rust-lang/cargo#17450)
- docs(lints): how to configure Cargo lints (rust-lang/cargo#17441)
- Fix relative symlink handling in write_atomic (rust-lang/cargo#17362)

r? ghost
@rustbot rustbot added this to the 1.100.0 milestone Sep 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-rebuild-detection Area: rebuild detection and fingerprinting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants