Repository navigation
Fixed stale comment about fingerprint checking method - #17450
Merged
Merged
Conversation
ranger-ross
force-pushed
the
fix-up-doc
branch
from
September 7, 2026 14:36
5e8754f to
5f54a18
Compare
weihanglo
approved these changes
Sep 7, 2026
weihanglo
enabled auto-merge
September 7, 2026 14:37
epage
approved these changes
Sep 7, 2026
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Sep 12, 2026
Update cargo submodule 6 commits in 3c0b534756e166d12eb9fd2e1abfe5b42ac6101e..7941be6fb416b4cd9666aef7b858dfea25587a8c 2026-09-04 17:03:10 +0000 to 2026-09-11 20:47:37 +0000 - fix(install): use packaged lockfile by default (rust-lang/cargo#17388) - test: add more comprehensive workspace feature unification tests (rust-lang/cargo#17466) - chore(deps): update crossbeam-epoch to 0.9.21 (rust-lang/cargo#17427) - Fixed stale comment about fingerprint checking method (rust-lang/cargo#17450) - docs(lints): how to configure Cargo lints (rust-lang/cargo#17441) - Fix relative symlink handling in write_atomic (rust-lang/cargo#17362) r? ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
I was reading the fingerprint logic docs (yet again) and noticed that the doc comment didn't seems to match the code.
Seem this doc comment got left behind in #17382.
Went ahead and updated to match the updated implementation.
How to test and review this PR?
just a comment
r? @epage