Repository navigation
feat(config): Add build.fingerprint - #17382
Merged
Merged
Conversation
rustbot
added
the
A-build-execution
Collaborator
|
r? @weihanglo rustbot has assigned @weihanglo. Use Why was this reviewer chosen?The reviewer was selected based on:
|
rustbot
added
A-documenting-cargo-itself
weihanglo
approved these changes
Aug 21, 2026
|
|
||
| Select the method used for detecting when a build should occur based on source input changes. | ||
|
|
||
| * `mtime`: Last modified time of the input |
Member
There was a problem hiding this comment.
IIRC we slightly floated an idea during the meeting, but couldn't find the note. Should we say "auto" or else, so we don't not lock ourselves in mtime? As we don't think mtime is the right direct and may want to change that in the future.
Though anyway this is not a merge blocker
Contributor
Author
There was a problem hiding this comment.
From what I remember, we were starting with standard mtime and checksum and then can always expand out to include a hybrid mode in the future, to keep this narrowly focused for getting stabilized. We can always change the default, deprecate values, etc.
weihanglo
enabled auto-merge
August 22, 2026 00:00
rustbot
removed
the
S-waiting-on-review
This was referenced Aug 22, 2026
4 tasks
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Aug 22, 2026
Update cargo submodule 5 commits in 514c56dd7321eecbfdcf9b6479519cf4edfab906..e8cb624d5701824f46a2ec5873cfd59ee3d2f66c 2026-08-19 00:31:04 +0000 to 2026-08-22 00:23:45 +0000 - feat(config): Add build.fingerprint (rust-lang/cargo#17382) - chore: bump to 0.101.0; update changelog (rust-lang/cargo#17379) - Install cargo tools with locked dependencies (rust-lang/cargo#17377) - test(compile): Clean up freshness tests (rust-lang/cargo#17376) - Fix clippy warning (rust-lang/cargo#17378) r? ghost
pull Bot
pushed a commit
to linyihai/cargo
that referenced
this pull request
Aug 23, 2026
### What does this PR try to resolve? Establishing a pattern of their use which should reduce needing review feedback like rust-lang#17382 (comment) See https://rust-lang.github.io/mdBook/format/markdown.html#admonitions ### How to test and review this PR?
pull Bot
pushed a commit
to TKaxv-7S/cargo
that referenced
this pull request
Sep 7, 2026
### What does this PR try to resolve? I was reading the fingerprint logic docs (yet again) and noticed that the doc comment didn't seems to match the code. Seem this doc comment got left behind in rust-lang#17382. Went ahead and updated to match the updated implementation. ### How to test and review this PR? just a comment r? @epage
ved-merget
pushed a commit
to Pufferfish-Merget/bench-cargo
that referenced
this pull request
Sep 15, 2026
### What does this PR try to resolve? Establishing a pattern of their use which should reduce needing review feedback like rust-lang/cargo#17382 (comment) See https://rust-lang.github.io/mdBook/format/markdown.html#admonitions ### How to test and review this PR?
ved-merget
pushed a commit
to Pufferfish-Merget/bench-cargo
that referenced
this pull request
Sep 15, 2026
### What does this PR try to resolve? I was reading the fingerprint logic docs (yet again) and noticed that the doc comment didn't seems to match the code. Seem this doc comment got left behind in rust-lang/cargo#17382. Went ahead and updated to match the updated implementation. ### How to test and review this PR? just a comment r? @epage
This was referenced Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
This is part of #14136
This changes
-Zchecksum-freshnessfrom turning on checksum freshness to enablingbuild.fingerprint.For
.cargo/config.toml:How to test and review this PR?