Added Windows remove_dir_all implementation from #31944#17
Conversation
|
Thanks for the PR! Perhaps this could use winapi instead of vendoring large parts of the standard library? (may also help readability as well) |
|
Practically all of that windows api stuff should be available in |
|
Neat! I agree that it would be better to use winapi here, and I'd also prefer if you would publish |
|
Next thing to do here is extract the function to its own crate, convert it to use winapi and then use that crate in tempdir. |
|
I have pulled it out into a new crate, |
|
@Aaronepower I opened a pr on |
|
@Aaronepower thank you! Looks like there's a bit more to do here before merging, but thanks for picking it up again. |
|
Thanks @Aaronepower! |
Various Windows related cleanups.
fixes #15