Skip to content
This repository was archived by the owner on Aug 20, 2021. It is now read-only.

Added Windows remove_dir_all implementation from #31944#17

Merged
brson merged 1 commit into
rust-lang-deprecated:masterfrom
XAMPPRocky:master
May 4, 2017
Merged

Added Windows remove_dir_all implementation from #31944#17
brson merged 1 commit into
rust-lang-deprecated:masterfrom
XAMPPRocky:master

Conversation

@XAMPPRocky

Copy link
Copy Markdown
Contributor

fixes #15

@alexcrichton

Copy link
Copy Markdown
Contributor

Thanks for the PR! Perhaps this could use winapi instead of vendoring large parts of the standard library? (may also help readability as well)

@retep998

retep998 commented Nov 9, 2016

Copy link
Copy Markdown

Practically all of that windows api stuff should be available in winapi.

@brson

brson commented Nov 17, 2016

Copy link
Copy Markdown
Contributor

Neat! I agree that it would be better to use winapi here, and I'd also prefer if you would publish remove_dir_all as a crate so others can use it as well.

@brson

brson commented Mar 11, 2017

Copy link
Copy Markdown
Contributor

Next thing to do here is extract the function to its own crate, convert it to use winapi and then use that crate in tempdir.

@XAMPPRocky

Copy link
Copy Markdown
Contributor Author

I have pulled it out into a new crate, remove_dir_all which now uses winapi.

@pwoolcoc

Copy link
Copy Markdown
Contributor

@Aaronepower I opened a pr on remove_dir_all that should fix the build issue

@brson

brson commented Apr 7, 2017

Copy link
Copy Markdown
Contributor

@Aaronepower thank you! Looks like there's a bit more to do here before merging, but thanks for picking it up again.

@XAMPPRocky

Copy link
Copy Markdown
Contributor Author

@brson I've updated it with @pwoolcoc 's changes. Seems like it works fine now!

@brson brson merged commit 8c3ed02 into rust-lang-deprecated:master May 4, 2017
@brson

brson commented May 4, 2017

Copy link
Copy Markdown
Contributor

Thanks @Aaronepower!

opilar pushed a commit to opilar/tempdir that referenced this pull request Sep 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TempDir affected by remove_dir_all unreliability on windows

5 participants