TempDir affected by remove_dir_all unreliability on windows

[brson]

I have test cases where TempDir fails to remove the directory mysteriously and irregularly.

cc rust-lang/rust#29497

[brson]

To fix this I'd suggest extracting the robust remove_dir_all impl from this unmerged PR, along with its test cases, and publishing it to crates.io, then updating TempDir to use that.

@alexcrichton does that sound reasonable to you?

[alexcrichton]

Sounds reasonable to me!

[XAMPPRocky]

I'd like to take this one on if that's alright?

[brson]

@Aaronepower Yes!

[brson]

There's an open but unfinished PR for this. What I'd like to happen yet:

• Move the code into a remove_dir_all_crate
• Write tests that capture that it works on windows in tricky cases cribbed from this issue.
• Use winapi instead of duplicating windows definitions
• Fix tempdir

[XAMPPRocky]

Yeah sorry, I had a winapi implementation however it was wrong, it failed the tests. And then I moved my main development over to macOS so it fell by the wayside. I plan to see if I can finish this over the weekend.

[brson]

Thanks @Aaronepower ! 😍