net/http.rb - fixup session timeout logic for OpenSSL 3#165
Closed
MSP-Greg wants to merge 2 commits intoruby:masterfrom
Closed
net/http.rb - fixup session timeout logic for OpenSSL 3#165MSP-Greg wants to merge 2 commits intoruby:masterfrom
MSP-Greg wants to merge 2 commits intoruby:masterfrom
Conversation
Contributor
Author
|
I tested this locally without the two commits affecting the test. In addition to this PR, commits 042faf7 & 58fc559 should be reverted, and PR #163 should be merged, which adds WIndows CI. At present, the only simple way to test against OpenSSL 3.2.0 is to use a Windows Ruby master build, either |
Contributor
Author
|
I just rebased and additionally: The branch is at https://github.com/MSP-Greg/net-http/commits/00-timeout-windows/, and CI passed. Windows Ruby head builds all use OpenSSL 3.2.1, Ruby 3.2 and 3.3 are using OpenSSL 3.2.0. |
Contributor
Author
|
Closing, see #178 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In OpenSSL 3,
session.timeoutmay not allow negative values, althoughcontext.timeoutcan be negative. For more info see ruby/openssl#703.Since the code here is using
session.timeoutin a non-standard way, usecontext.timeout. If it's nil, usesession.timeout. This allows the code to work with OpenSSL 3.2.0.