test/net/http/test_https.rb - fixup session reuse tests#162
Closed
MSP-Greg wants to merge 1 commit intoruby:masterfrom
Closed
test/net/http/test_https.rb - fixup session reuse tests#162MSP-Greg wants to merge 1 commit intoruby:masterfrom
MSP-Greg wants to merge 1 commit intoruby:masterfrom
Conversation
Contributor
Author
|
Duplicate of ruby/ruby#9033. Not sure which is preferred. |
This was referenced Nov 25, 2023
Member
|
I wonder why this is failing on Windows only, as it doesn't seem to be relying on platform-dependent features. |
Contributor
Author
|
Yesterday (Thanksgiving) was not a good day for finding a block of time to work on this. It's obviously upstream of net-http. I just noticed that MSYS2 has already jumped to OpenSSL 3.2.0. Note that the only build 'fully' using it is the urcrt build, as head is still a bit of both (see here). I suspect MSFT/vcpkg will update soon also, but it's still using 3.1.4. I'm going to add ucrt to #163 and see if it passes... |
Contributor
Author
|
I ran CI in my fork of ruby/openssl, and Windows ucrt passed. Is this covered by the tests there? |
Contributor
Author
|
Closing in favor of #165 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
test_session_reuse_with_timeouttest, which verifies that settingssl_timeoutwill allow session reuse. Another test checks that not settingssl_timeoutworks, as it uses OpenSSL's default value.Rename
test_session_reuse_but_expiretotest_session_reuse_with_expired_timeoutand fixup for WIndows mingw/ucrt builds.