fixes block() in MetadataPushRequesterMono/FnfRequesterMono#1044
Merged
OlegDokuka merged 2 commits intomasterfrom Mar 28, 2022
Merged
fixes block() in MetadataPushRequesterMono/FnfRequesterMono#1044OlegDokuka merged 2 commits intomasterfrom
block() in MetadataPushRequesterMono/FnfRequesterMono#1044OlegDokuka merged 2 commits intomasterfrom
Conversation
Signed-off-by: Oleh Dokuka <odokuka@vmware.com> Signed-off-by: Oleh Dokuka <oleh.dokuka@icloud.com>
rstoyanchev
approved these changes
Mar 28, 2022
Contributor
There was a problem hiding this comment.
Looks good.
However, considering the description under #1034:
faulty implementation of the block method, which in turn was a near-duplicate of the subscribe method. Mono's implementation of the block methods already delegate to subscribe in a safe way, as it seems, so there seems to be no obvious (documented) reason why the block method needs to be overridden.
It would be good to add to the Java doc of those block methods that explains the reason they are there.
OlegDokuka
changed the title
block() in MetadataPushRequesterMonoblock() in MetadataPushRequesterMono/FnfRequesterMono
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1033. Supersedes #1034
Signed-off-by: Oleh Dokuka odokuka@vmware.com
Signed-off-by: Oleh Dokuka oleh.dokuka@icloud.com