Removed overrides for block() methods#1034
Closed
abuijze wants to merge 1 commit intorsocket:masterfrom
abuijze:remove-block-implementations
Closed
Removed overrides for block() methods#1034abuijze wants to merge 1 commit intorsocket:masterfrom abuijze:remove-block-implementations
abuijze wants to merge 1 commit intorsocket:masterfrom
abuijze:remove-block-implementations
Conversation
Contributor
|
This was fixed but never closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed overrides for block() methods
Motivation:
Issue #1033 was caused by a faulty implementation of the block method, which in turn was a near-duplicate of the subscribe method. Mono's implementation of the block methods already delegate to subscribe in a safe way, as it seems, so there seems to be no obvious (documented) reason why the block method needs to be overridden.
Furthermore, the
block(Duration)method simply delegated toblock(), which doesn't honor the semantics of the interface.Modifications:
Removed the implementation of
block()andblock(Duration), relying on the implementation in theMonoclass.Result:
Resolves #1033. It also removes near-duplicate code, which is generally a source of issues (such as #1033).