Repository navigation
fix(config): ignore editor name metadata in typo warnings - #2959
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review: 2
Please check the settings in the CodeRabbit UI or the
|
🤖 Internal: Discord sync markerAuto-managed by the Discord notification workflow. Stores the linked Discord message ID and forum thread ID. Do not edit or delete. |
asclearuc
left a comment
There was a problem hiding this comment.
Thanks @Leela8256 — this is the same patch as #2958 (identical blobs for both files), on a current stage (merge base 2026-11-02, 0 commits behind), and CI is green here too.
Approve
No inline comments.
dk-rocketride
left a comment
There was a problem hiding this comment.
Looks right: name is skipped only in the misnamed-key warning, it stays in the merged config, and the third test shows a real typo next to it (serverNam) is still reported.
Summary
unknown config key "name" - did you mean "serverName"?, interrupting normal Save completion. The editor suppliesconfig.name; the engine's suffix-based typo detector mistakes it for the node's tool-server setting.namefrom that check. This shared validator correction also benefits other nodes with the same false warning; genuine typos such asserverNamstill warn, and configuration values remain intact.Type
fix
Testing
./builder testpasses — full monorepo suite not run75 targeted Python tests pass on both target bases:
test_config_key_warnings.py,test_config_shapes.py, andtest_output_token_config.py. Ruff lint/format, the staged secret scan, andgit diff --checkpass.Real authenticated local-engine validation returned no errors or warnings for all four toggle combinations with
config.namepresent; a deliberateserverNamtypo still warned. The local preview was rebuilt with the original UI Save behavior. Browser/Cursor Save-and-reopen verification remains outstanding because browser automation was unavailable. Mounted React checks used backend/persistence test doubles.The develop and stage branches contain byte-identical patches and identical resulting blobs for both changed files. Each branch contains only this fix and its tests on its own target base.
Checklist
Linked Issue
Fixes #2957