Skip to content

fix(config): ignore editor name metadata in typo warnings - #2959

Merged
Leela8256 merged 1 commit into
stagefrom
fix/RR-2957-vector-node-config-warning-stage
Nov 3, 2026
Merged

Leela8256 merged 1 commit into
stagefrom
fix/RR-2957-vector-node-config-warning-stage

Conversation

@Leela8256

Copy link
Copy Markdown
Collaborator

Summary

  • Saving a named RocketRide Vector node can report unknown config key "name" - did you mean "serverName"?, interrupting normal Save completion. The editor supplies config.name; the engine's suffix-based typo detector mistakes it for the node's tool-server setting.
  • Exclude the exact editor metadata key name from that check. This shared validator correction also benefits other nodes with the same false warning; genuine typos such as serverNam still warn, and configuration values remain intact.
  • Add catalog coverage and all four vector tool-toggle combinations in flat and nested profiles. The UI and its existing warning/error Save behavior are unchanged.

Type

fix

Testing

  • Tests added or updated
  • Tested locally
  • ./builder test passes — full monorepo suite not run

75 targeted Python tests pass on both target bases: test_config_key_warnings.py, test_config_shapes.py, and test_output_token_config.py. Ruff lint/format, the staged secret scan, and git diff --check pass.

Real authenticated local-engine validation returned no errors or warnings for all four toggle combinations with config.name present; a deliberate serverNam typo still warned. The local preview was rebuilt with the original UI Save behavior. Browser/Cursor Save-and-reopen verification remains outstanding because browser automation was unavailable. Mounted React checks used backend/persistence test doubles.

The develop and stage branches contain byte-identical patches and identical resulting blobs for both changed files. Each branch contains only this fix and its tests on its own target base.

Checklist

  • Commit messages follow conventional commits
  • No secrets or credentials included
  • Wiki updated (if applicable) — not applicable
  • Breaking changes documented (if applicable) — none

Linked Issue

Fixes #2957

@coderabbitai

coderabbitai Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review: 2
  • develop
  • release/.*

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor
🤖 Internal: Discord sync marker

Auto-managed by the Discord notification workflow. Stores the linked Discord message ID and forum thread ID. Do not edit or delete.

@asclearuc asclearuc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Leela8256 — this is the same patch as #2958 (identical blobs for both files), on a current stage (merge base 2026-11-02, 0 commits behind), and CI is green here too.

Approve

No inline comments.

@Leela8256
Leela8256 merged commit bfaceb1 into stage Nov 3, 2026
@Leela8256
Leela8256 deleted the fix/RR-2957-vector-node-config-warning-stage branch November 3, 2026 15:24

@dk-rocketride dk-rocketride left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right: name is skipped only in the misnamed-key warning, it stays in the merged config, and the third test shows a real typo next to it (serverNam) is still reported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:ai AI/ML modules tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants