Repository navigation
fix(config): ignore editor name metadata in typo warnings - #2958
Conversation
🤖 Internal: Discord sync markerAuto-managed by the Discord notification workflow. Stores the linked Discord message ID and forum thread ID. Do not edit or delete. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
asclearuc
left a comment
There was a problem hiding this comment.
Thanks @Leela8256 — a narrow fix in the right place. The shared validator skips only the editor's name key, a real near-miss such as serverNam still warns, and the catalogue-wide test proves that name no longer warns on any node.
Approve
No inline comments. #2959 carries the same patch to stage.
dsapandora
left a comment
There was a problem hiding this comment.
One change needed inline.
| # The editor supplies this common endpoint/display field even when | ||
| # services.json does not declare it. It is not a truncated | ||
| # serverName/accountName/etc. Keep it in the merged config. | ||
| if key == 'name': |
There was a problem hiding this comment.
The editor also writes config.type, and it still warns: examples/cognee-shared-memory-agents.pipe gives unknown config key "type" - did you mean "search_type"?, and tool_http_request suggests authType. Please skip both editor keys ({"name", "type"}) and add a type case to the catalogue test.
The canvas saves the node's type inside its config ("type": "tool_github"). The
config key check read that key as a misspelling of a declared field (authType on
tool_github, compute_type on audio_transcribe) and warned on every pipeline saved
from the canvas. Exempt "type" the way #2958 exempted "name"; a real typo such as
"serverNam" still warns.
Follow-up to #2958 (issue #2957).
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Summary
unknown config key "name" - did you mean "serverName"?, interrupting normal Save completion. The editor suppliesconfig.name; the engine's suffix-based typo detector mistakes it for the node's tool-server setting.namefrom that check. This shared validator correction also benefits other nodes with the same false warning; genuine typos such asserverNamstill warn, and configuration values remain intact.Type
fix
Testing
./builder testpasses — full monorepo suite not run75 targeted Python tests pass on both target bases:
test_config_key_warnings.py,test_config_shapes.py, andtest_output_token_config.py. Ruff lint/format, the staged secret scan, andgit diff --checkpass.Real authenticated local-engine validation returned no errors or warnings for all four toggle combinations with
config.namepresent; a deliberateserverNamtypo still warned. The local preview was rebuilt with the original UI Save behavior. Browser/Cursor Save-and-reopen verification remains outstanding because browser automation was unavailable. Mounted React checks used backend/persistence test doubles.The develop and stage branches contain byte-identical patches and identical resulting blobs for both changed files. Each branch contains only this fix and its tests on its own target base.
Checklist
Linked Issue
Fixes #2957
Summary by CodeRabbit