Skip to content

fix: setValidState embed API fails with tr=inf and no grain #9824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AdityaHegde merged 2 commits into from
Aug 21, 2026
+31 −3
Merged

fix: setValidState embed API fails with tr=inf and no grain #9824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2716612
fix: setValidState embed API fails with tr=inf and no grain
AdityaHegde Aug 20, 2026
0a483c3
Add direct convertURLSearchParamsToExploreState tests
AdityaHegde Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 28 additions & 1 deletion ...tate/invalid-url-state-variations.spec.ts → ...vertURLSearchParamsToExploreState.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,28 @@ Unexpected " ".`,
},
},

{
title: "Time range only with default grain",
url: "http://localhost/explore/AdBids_explore?tr=7D",
errors: [],
entity: {
selectedTimeRange: {
interval: "TIME_GRAIN_DAY",
name: "7D",
} as DashboardTimeControls,
},
},
{
title: "Time range only with no default grain",
url: "http://localhost/explore/AdBids_explore?tr=inf",
errors: [],
entity: {
selectedTimeRange: {
interval: "TIME_GRAIN_HOUR",
name: "inf",
} as DashboardTimeControls,
},
},
{
title: "Invalid time ranges",
url: "http://localhost/explore/AdBids_explore?tr=abc&grain=xyz",
Expand Down Expand Up @@ -131,7 +153,12 @@ Unexpected " ".`,
},
];

describe("Invalid Human readable URL State", () => {
/**
* Has tests that call convertURLSearchParamsToExploreState directly.
* Unlike url-state-variations that tests actions on explore state.
* TODO: find a good unification of test cases so that a single set of cases run all variations.
*/
describe("direct convertURLSearchParamsToExploreState variations", () => {
beforeEach(() => {
metricsExplorerStore.remove(AD_BIDS_EXPLORE_NAME);
});
Expand Down
5 changes: 3 additions & 2 deletions web-common/src/features/dashboards/url-state/convertURLToExplorePreset.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,8 +390,9 @@ export function fromTimeRangesParams(

if (grain && grain in V1TimeGrainToDateTimeUnit) {
preset.timeGrain = V1TimeGrainToDateTimeUnit[grain];
} else {
errors.push(getSingleFieldError("time grain", grain ?? "undefined"));
} else if (grain) {
Comment thread
AdityaHegde marked this conversation as resolved.
// Only throw error if grain is defined
errors.push(getSingleFieldError("time grain", grain));
}
} catch {
// ignore
Expand Down
Loading