fix: setValidState embed API fails with tr=inf and no grain - #9824
Open
AdityaHegde wants to merge 2 commits into
Open
fix: setValidState embed API fails with tr=inf and no grain#9824AdityaHegde wants to merge 2 commits into
AdityaHegde wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Allows all-time URL ranges without an explicit grain to pass validation.
Changes:
- Only reports invalid derived grains when a grain exists.
- Leaves missing grains for downstream backfilling.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
pjain1
approved these changes
Aug 20, 2026
pjain1
left a comment
Member
There was a problem hiding this comment.
There is a comment from copilot.
nishantmonu51
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
setValidStatewithtr=infin the url param and no grain would return an error,Selected time grain: "undefined" is not valid.This is because we do not have a valid derived grain for inf time range, but an error here doesnt make sense.Updating to only throw when the derived grain is valid. Absense of grain will be backfilled in other parts of the code. A unification of time controls calc is pending, this should be fixed there and the backfilled grain should be derived upfront.
Checklist: