Skip to content

Make invalid accessibility roles non-fatal (#58803) #58803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Abbondanzo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make invalid accessibility roles non-fatal (#58803) #58803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...ive/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactAccessibilityDelegate.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,6 +499,7 @@ public open class ReactAccessibilityDelegate( // The View this delegate is attac
}
}

/** Returns the matching role, or [NONE] when [value] is null or unrecognized. */
@JvmStatic
public fun fromValue(value: String?): AccessibilityRole {
if (value == null) {
Expand All @@ -510,7 +511,7 @@ public open class ReactAccessibilityDelegate( // The View this delegate is attac
return role
}
}
throw IllegalArgumentException("Invalid accessibility role value: $value")
return NONE
}

@JvmStatic
Expand Down
7 changes: 7 additions & 0 deletions ...ReactAndroid/src/test/java/com/facebook/react/uimanager/ReactAccessibilityDelegateTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,6 +356,13 @@ class ReactAccessibilityDelegateTest {
.isEqualTo("android.view.View")
}

@Test
fun testAccessibilityRole_fromValue_invalidRole_returnsNone() {
val role = ReactAccessibilityDelegate.AccessibilityRole.fromValue("invalid-role")

assertThat(role).isEqualTo(ReactAccessibilityDelegate.AccessibilityRole.NONE)
}

@Test
fun testPerformAccessibilityAction_collapseAction_fromAccessibilityActions() {
val accessibilityActions = JavaOnlyArray()
Expand Down
Loading