Make invalid accessibility roles non-fatal (#58803) - #58803
Open
Abbondanzo wants to merge 1 commit into
Open
Abbondanzo wants to merge 1 commit into
Abbondanzo wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@Abbondanzo has exported this pull request. If you are a Meta employee, you can view the originating Diff in D122813073. |
Summary: `AccessibilityRole.fromValue` throws for an unrecognized role and can crash Android rendering. Return `NONE` for unknown values instead. It doesn't make sense to throw here, especially since different platforms like iOS support different values Changelog: [Android][Fixed] - Prevent invalid `accessibilityRole` values from crashing the app. Differential Revision: D122813073
meta-codesync
Bot
changed the title
Abbondanzo
force-pushed
the
export-D122813073
branch
from
October 2, 2026 21:36
a83edde to
30032c8
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
AccessibilityRole.fromValuethrows for an unrecognized role and can crash Android rendering. ReturnNONEfor unknown values instead. It doesn't make sense to throw here, especially since different platforms like iOS support different valuesChangelog:
[Android][Fixed] - Prevent invalid
accessibilityRolevalues from crashing the app.Differential Revision: D122813073