Skip to content

Modularize 3: remote function execution#2602

Closed
suquark wants to merge 29 commits into
ray-project:masterfrom
suquark:modularize-3-remote_function_execution
Closed

Modularize 3: remote function execution#2602
suquark wants to merge 29 commits into
ray-project:masterfrom
suquark:modularize-3-remote_function_execution

Conversation

@suquark

@suquark suquark commented Aug 8, 2018

Copy link
Copy Markdown
Member

What do these changes do?

As suggested, I divide #2577 into several shorter parts.
This is the third part of #2577 which follows #2597 & #2599, which modularize remote function execution. Please review and merge #2597 & #2599 first.

Because this is a PR reconstructed from #2577, the commits are improved and well-designed for reviewers to read through.

Related issue number

#2016
#614

suquark added 10 commits August 7, 2018 16:25
It is because many modules will share them later.
Separate it can avoid circular reference.
Check attr first before disconnect. `plasma_client` attr only exists
after connecting.
…nt`.

This is because we moved `serialization_context_map` out before and
`_initialize_serialization` depends on it.
Because they are frequently use for judging `Worker`'s type. It is
especially useful when we want access worker outside.
@AmplabJenkins

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/7327/
Test PASSed.

@AmplabJenkins

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/7334/
Test PASSed.

@AmplabJenkins

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/7377/
Test FAILed.

@suquark suquark force-pushed the modularize-3-remote_function_execution branch from d897330 to c1d77ff Compare August 9, 2018 10:31
@suquark suquark force-pushed the modularize-3-remote_function_execution branch from c1d77ff to 2991f5c Compare August 9, 2018 10:55
@suquark suquark force-pushed the modularize-3-remote_function_execution branch from 2991f5c to 60b057a Compare August 9, 2018 11:00
@AmplabJenkins

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/7382/
Test PASSed.

@AmplabJenkins

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/7384/
Test PASSed.

@AmplabJenkins

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/7385/
Test PASSed.

@robertnishihara

Copy link
Copy Markdown
Collaborator

Closing for now due to staleness. The overall refactoring is still very important though.

@suquark suquark deleted the modularize-3-remote_function_execution branch September 2, 2019 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants