Modularize 2: serialization#2599
Closed
suquark wants to merge 17 commits into
Closed
Conversation
It is because many modules will share them later. Separate it can avoid circular reference.
Check attr first before disconnect. `plasma_client` attr only exists after connecting.
…nt`. This is because we moved `serialization_context_map` out before and `_initialize_serialization` depends on it.
Because they are frequently use for judging `Worker`'s type. It is especially useful when we want access worker outside.
|
Test PASSed. |
This was referenced Aug 8, 2018
|
Test FAILed. |
suquark
force-pushed
the
modularize-2-serialization
branch
from
4458920 to
1a4e064
Compare
|
Test PASSed. |
|
Test FAILed. |
Collaborator
|
Closing for now due to staleness. The overall refactoring is still very important though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
As suggested, I divide #2577 into several shorter parts.
This is the second part of #2577 follows #2597, which modularize serialization. Please review and merge #2597 first.
Because this is a PR reconstructed from #2577, the commits are improved and well-designed for reviewers to read through.
Related issue number
#2016
#614