gh-130167: Improve the error case for textwrap.dedent#132666
Merged
AA-Turner merged 5 commits intopython:mainfrom Apr 19, 2025
Merged
gh-130167: Improve the error case for textwrap.dedent#132666AA-Turner merged 5 commits intopython:mainfrom
textwrap.dedent#132666AA-Turner merged 5 commits intopython:mainfrom
Conversation
Contributor
|
Would it be possible to add a test for this? |
picnixz
reviewed
Apr 18, 2025
Contributor
|
Thanks. I suppose bytes would still TypeError implicitly, right? |
Member
Author
|
Yes, but with an error message from |
picnixz
approved these changes
Apr 19, 2025
Member
picnixz
left a comment
picnixz
left a comment
There was a problem hiding this comment.
Out of curiosity, can we have the benchmarks for this change on empty strings? I don't think we lose much but I'm just curious.
Member
Author
|
I won't have time in the near future to run benchmarks. A |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @hroncok @picnixz
reuses #130167