gh-130167: Add a What's New entry for changes to textwrap.{de,in}dent#131924
gh-130167: Add a What's New entry for changes to textwrap.{de,in}dent#131924hugovk merged 4 commits intopython:mainfrom
textwrap.{de,in}dent#131924Conversation
picnixz
left a comment
picnixz
left a comment
There was a problem hiding this comment.
There is a note:
Note that tabs and spaces are both treated as whitespace, but they are not
equal: the lines ``" hello"`` and ``"\thello"`` are considered to have no
common leading whitespace.
The new implementation still guarantees this right?
Doc/whatsnew/3.14.rst
Outdated
| characters other than space and tab. | ||
|
|
There was a problem hiding this comment.
Add something like (to be able to see the issue)
characters other than space and tab.
(Contributed by [...] in :gh:`...`.)
+ 2 blank lines to end the section.
picnixz
changed the title
textwrap.dedenttextwrap.dedent
Doc/whatsnew/3.14.rst
Outdated
|
|
||
| * Optimise the :func:`~textwrap.dedent` function, improving performance by | ||
| an average of 2.4x, with larger improvements for bigger inputs, | ||
| and fix a bug with incomplete normalization of blank lines with whitespace |
There was a problem hiding this comment.
Maybe use two separate bullet points for that? so that the reader is able to distinguish between a performance improvement and a behavioral change.
There was a problem hiding this comment.
Where should the second one go? Improved Modules is mainly for features, and a standalone bullet about the bugfix in Optimisations feels wrong.
There was a problem hiding this comment.
Well, I think it's still an improvement in some sense (even if we didn't treat it as a regular bugfix that we backport). For me I think that the behavioral change is important to note, hence I suggested using two separate bullet points (but still under the same section)
AA-Turner
changed the title
textwrap.dedenttextwrap.{de,in}dent
AA-Turner
changed the title
textwrap.{de,in}denttextwrap.{de,in}dent
|
All commit authors signed the Contributor License Agreement. |
|
@AA-Turner Can you also include the typo fix of the NEWS entry (https://github.com/python/cpython/pull/131923/files#r2044429846)? TiA |
|
Reminder for this :) |
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
LGTM. I have no opinion about normalised/normalized, please came to some conclusion.
(Was fixed in #132666) |
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
Thanks @AA-Turner for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
…,in}dent`` (pythonGH-131924) (cherry picked from commit 7e3a5a7) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
|
GH-143292 is a backport of this pull request to the 3.14 branch. |
…e,in}dent`` (GH-131924) (#143292) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
5 participants
📚 Documentation preview 📚: https://cpython-previews--131924.org.readthedocs.build/
reuses #130167