Skip to content

add validator TRX addresses (TRC20)#277

Closed
msamsami wants to merge 63 commits intopython-validators:masterfrom
msamsami:add-trx-validator
Closed

add validator TRX addresses (TRC20)#277
msamsami wants to merge 63 commits intopython-validators:masterfrom
msamsami:add-trx-validator

Conversation

@msamsami
Copy link
Copy Markdown
Contributor

This is a validator for TRC20 Tron (TRX) addresses.

@nandgator
Copy link
Copy Markdown
Collaborator

Hi @msamsami thanks for the PR.

Can you move both #276 & #277 to a folder crypto_addresses under validators, like so?

.
|---- validators
    |---- crypto_addresses
        |---- eth_address.py
        |---- trx_address.py

And do the same with their corresponding tests?

@nandgator nandgator added waiting Issue/PR: Wating for reply enhancement Issue/PR: A new feature labels Jun 12, 2023
@msamsami
Copy link
Copy Markdown
Contributor Author

Hi @joe733

Sure. I'll move btc_address.py and its test to the new directories as well.

@nandgator nandgator removed the waiting Issue/PR: Wating for reply label Jun 12, 2023
@msamsami
Copy link
Copy Markdown
Contributor Author

msamsami commented Jun 12, 2023

Hi @msamsami thanks for the PR.

Can you move both #276 & #277 to a folder crypto_addresses under validators, like so?

.
|---- validators
    |---- crypto_addresses
        |---- eth_address.py
        |---- trx_address.py

And do the same with their corresponding tests?

Hi @joe733

It's done. Please merge #276 first and then #277 to avoid any conflicts. The final structure would be like this:

.
|---- tests
    |---- crypto_addresses
        |---- __init__.py
        |---- test_btc_address.py
        |---- test_eth_address.py
        |---- test_trx_address.py

|---- validators
    |---- crypto_addresses
        |---- __init__.py
        |---- btc_address.py
        |---- eth_address.py
        |---- trx_address.py

@nandgator
Copy link
Copy Markdown
Collaborator

@msamsami please sync add-trx-validator branch from upstream.

@nandgator nandgator force-pushed the master branch 8 times, most recently from 73d540f to 0c97dde Compare August 7, 2023 08:48
@nandgator nandgator added the outdated Issue/PR: Open for more than 3 months label Nov 7, 2023
@nandgator
Copy link
Copy Markdown
Collaborator

Ref: #278 (comment)

@nandgator nandgator closed this Apr 4, 2024
@msamsami msamsami deleted the add-trx-validator branch July 2, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Issue/PR: A new feature outdated Issue/PR: Open for more than 3 months

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants