add validator ETH addresses (ERC20)#276
Conversation
nandgator
left a comment
There was a problem hiding this comment.
Just one more change.
| # external | ||
| import re | ||
|
|
||
| from eth_hash.auto import keccak | ||
|
|
||
| # local | ||
| from validators.utils import validator |
There was a problem hiding this comment.
@msamsami, I meant the change to be as follows:
# standard
import re
# external
from eth_hash.auto import keccak
# local
from validators.utils import validatorAs re is from the standard library, eth_hash.auto.keccak is an external dependency and validators.utils.validator implies a local coupling.
|
Tests have failed. Ref: https://github.com/python-validators/validators/actions/runs/5387269990/jobs/9778426797?pr=276#step:6:182 Also, please use Instead if you simply run |
|
@joe733 I added backend dependencies of |
|
@msamsami thanks for the PR! |
This is a validator for ERC20 Ethereum (ETC) addresses.