reports: use attr.asdict with serialize_repr_{crash,traceback}#6732
Merged
Conversation
1 task
blueyed
commented
Feb 13, 2020
| reprentries = attr.ib(type=Sequence[Union["ReprEntry", "ReprEntryNative"]]) | ||
| extraline = attr.ib(type=Optional[str]) | ||
| style = attr.ib(type="_TracebackStyle") | ||
| style = style |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| style = style |
Member
|
LGTM, though I think it will be better to also convert |
Member
That would be ideal, but let's not hold this PR on that (I don't think here will be any weird interactions). Let's leave it up to @blueyed if he wants to tackle converting the other classes or not. |
nicoddemus
approved these changes
Feb 14, 2020
Contributor
Author
|
It's not trivial for all of them, but will create a WIP PR for it already. |
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Feb 15, 2020
…t-dev#6732) * Turn ReprTraceback into attrs class * Use attr.asdict with serialize_repr_{crash,traceback} * Turn ReprFileLocation into attrs class, convert py.path.local (cherry picked from commit 9631b3c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This helps with skipping "private" properties there.