[WIP] Cache TerminalRepr.__str__#219
Closed
blueyed wants to merge 3 commits into
Closed
Conversation
blueyed
changed the title
TerminalRepr.__str__ a cached propertyTerminalRepr.__str__
…t-dev#6732) * Turn ReprTraceback into attrs class * Use attr.asdict with serialize_repr_{crash,traceback} * Turn ReprFileLocation into attrs class, convert py.path.local (cherry picked from commit 9631b3c)
blueyed
force-pushed
the
TerminalRepr-cached-str
branch
from
bd7099a to
dfdd2b9
Compare
TODO: add test / attrs's frozen
Owner
Author
|
Typically only accessed once, not worth it for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
attrs part upstreamed: pytest-dev#6732
TODO: