Skip to content

Make "--pdb" imply "--dist no"#550

Merged
nicoddemus merged 2 commits into
pytest-dev:masterfrom
adamchainz:issue_549_pdb_dist
Jul 24, 2020
Merged

Make "--pdb" imply "--dist no"#550
nicoddemus merged 2 commits into
pytest-dev:masterfrom
adamchainz:issue_549_pdb_dist

Conversation

@adamchainz

@adamchainz adamchainz commented Jul 3, 2020

Copy link
Copy Markdown
Member

Fixes #549.

Here's a quick checklist that should be present in PRs:

  • Make sure to include reasonable tests for your change if necessary

  • We use towncrier for changelog management, so please add a news file into the changelog folder following these guidelines:

    • Name it $issue_id.$type for example 588.bugfix;

    • If you don't have an issue_id change it to the PR id after creating it

    • Ensure type is one of removal, feature, bugfix, vendor, doc or trivial

    • Make sure to use full sentences with correct case and punctuation, for example:

      Fix issue with non-ascii contents in doctest text files.
      

@blueyed

blueyed commented Jul 7, 2020

Copy link
Copy Markdown
Contributor

Maybe relevant: #502

@adamchainz

Copy link
Copy Markdown
Member Author

Yes, will happily rebase if that gets merged.

@adamchainz
adamchainz force-pushed the issue_549_pdb_dist branch from 8f12ee6 to 0058f5a Compare July 24, 2020 16:11
@adamchainz

Copy link
Copy Markdown
Member Author

Tests are now passing since master got fixed.

@adamchainz

Copy link
Copy Markdown
Member Author

Thanks for the update

@nicoddemus
nicoddemus merged commit b524317 into pytest-dev:master Jul 24, 2020
@nicoddemus

Copy link
Copy Markdown
Member

Thanks a lot @adamchainz! 🙇

@adamchainz
adamchainz deleted the issue_549_pdb_dist branch July 25, 2020 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make "--pdb" imply "--dist no"

3 participants