Move checking of options to pytest_configure#502
Closed
blueyed wants to merge 3 commits into
Closed
Conversation
This allows for `pytest -n 2 --pdb` to stop / help with errors before/during `pytest_configure`. It also appears to be sensible to check the config in the hook meant for it, instead of in `pytest_cmdline_main`.
Member
|
This seems sensible |
Member
|
Closing as stale. |
Contributor
Author
I agree. |
Contributor
Author
Why? |
Member
|
Realistically nobody seems to be looking at it/wanting to merge it, so I decided to close it to clear the PR queue. Reopening. |
This was referenced Apr 28, 2021
Member
|
Closing as nobody is willing to work on it. Feel free to reopen if you can make it pass CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows for
pytest -n 2 --pdbto stop / help with errorsbefore/during
pytest_configure.It also appears to be sensible to check the config in the hook meant for
it, instead of in
pytest_cmdline_main.TODO (after approval):