Skip duplicate actions when pushing in this repository - #45
Merged
Conversation
Contributor
Author
|
...evidently this doesn't work :/ I'll have to figure it out later. |
Merged
Currently when someone pushes a branch directly to pytest-localserver, we get two copies of each Github action, one for the push and one for the pull request. This change should skip the pull_request action for branches pushed directly into pytest-localserver. It won't affect branches coming from other people's forks.
diazona
force-pushed
the
avoid-duplicate-actions/1/dev
branch
from
July 17, 2022 08:48
c86d1e8 to
0e0ce0c
Compare
diazona
added a commit
to diazona/setuptools-pyproject-migration
that referenced
this pull request
Jul 8, 2023
Currently when creating a pull request (at least, one not in a fork, but at the moment there are no forks anyway), we get two copies of each Github action, one for the branch push and one for the pull request. The change in this commit should skip the action running for the pull request whenever the source branch exists locally in this repository. It shouldn't affect branches coming from other people's forks, if there are forks in the future. I copied the logic to do this from another project in which I worked out how to do the same thing: pytest-dev/pytest-localserver#45 The comment I've added to the workflow refers to a blog post I relied on when figuring out how to make this work for that other project.
diazona
added a commit
to diazona/setuptools-pyproject-migration
that referenced
this pull request
Jul 9, 2023
Currently when creating a pull request (at least, one not in a fork, but at the moment there are no forks anyway), we get two copies of each Github action, one for the branch push and one for the pull request. The change in this commit should skip the action running for the pull request whenever the source branch exists locally in this repository. It shouldn't affect branches coming from other people's forks, if there are forks in the future. I copied the logic to do this from another project in which I worked out how to do the same thing: pytest-dev/pytest-localserver#45 The comment I've added to the workflow refers to a blog post I relied on when figuring out how to make this work for that other project.
diazona
added a commit
to diazona/setuptools-pyproject-migration
that referenced
this pull request
Jul 9, 2023
Currently when creating a pull request (at least, one not in a fork, but at the moment there are no forks anyway), we get two copies of each Github action, one for the branch push and one for the pull request. The change in this commit should skip the action running for the pull request whenever the source branch exists locally in this repository. It shouldn't affect branches coming from other people's forks, if there are forks in the future. I copied the logic to do this from another project in which I worked out how to do the same thing: pytest-dev/pytest-localserver#45 The comment I've added to the workflow refers to a blog post I relied on when figuring out how to make this work for that other project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when someone pushes a branch directly to pytest-localserver, we get two copies of each Github action, one for the push and one for the pull request. This change should skip the pull_request action for branches pushed directly into this repository. It won't affect branches coming from other people's forks.