Relax dependencies - #44
Merged
Merged
Conversation
Contributor
|
Just checked. pytest 6.2.4 needs Python >=3.6.
|
Contributor
Author
|
Ah, thanks! I want to get rid of the duplicate pipelines (#45) first, and then I'll push a fix. |
We have a constraint that limits the maximum supported version of pytest to the current major version, under the assumption that a new major version release may break backwards compatibility. Now that pytest 7 has been tested and is known to work with pytest-localserver, we can relax the constraint to mark it as supported.
I confirmed that tests pass with pytest 6.2.4 by running tox -r -e py310,py311 --force-dep pytest==6.2.4 Running the corresponding command for pytest 6.2.3 does not pass, so this is the lowest version we can support on Python 3.10+.
diazona
force-pushed
the
relax-dependencies/1/dev
branch
from
July 18, 2022 00:42
048bb2d to
9bd09f8
Compare
Contributor
Author
|
This appears to be working now... but strangely, the check with pypy-3.9, smtp, and pytest 6.2.4 failed at first, then I reran it (with no changes) and it succeeded. This isn't the first time I've noticed what seems like inconsistent behavior from the automated checks, but it is the most blatant. So we should watch out for that in the future. |
I've edited the Github workflows configuration to run tests with the lowest version of pytest marked as supported. If anything in a future commit breaks compatibility with those versions, we'll be alerted by a test failure and we can adjust the version compatibility accordingly.
diazona
force-pushed
the
relax-dependencies/1/dev
branch
from
July 18, 2022 00:57
9bd09f8 to
4b1d9ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This expands the range of allowed pytest versions to be 6.2.4 to 7.X (inclusive), and adds some more tests to verify functionality of the package with the edge versions.
Closes #41