🐛 fix(env): reject a file as --env-dir and drop a mutable default#1100
Merged
Conversation
- Raise BuildException when --env-dir points at a regular file instead of letting os.makedirs produce a raw FileExistsError - Change mutable default `constraints: Collection[str] = []` to `()` (B006) - Add a test asserting the new "not a directory" error path Assisted-by: ClaudeCode:claude-sonnet-4.6
Assisted-by: ClaudeCode:claude-sonnet-4.6
Assisted-by: ClaudeCode:claude-opus-4.8
gaborbernat
approved these changes
Jun 13, 2026
layday
approved these changes
Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Two small robustness fixes in
DefaultIsolatedEnv:--env-dirpoints at an existing regular file,os.makedirs(..., exist_ok=True)previously raised a rawFileExistsError. Now aBuildExceptionwith a clear message (Build environment location is not a directory: <path>) is raised before reachingos.makedirs. A sibling test is added alongside the existingtest_env_dir_rejects_non_empty_locationtest.DefaultIsolatedEnv.install'sconstraintsparameter had a mutable default[](ruff B006). Changed to an empty tuple().Refs #1097