🐛 fix(cli): drain verbose subprocess output without a worker thread#1098
Merged
Conversation
The single-worker ThreadPoolExecutor in the verbose subprocess path added complexity without benefit: stderr is merged into stdout so there is only one stream, and concurrent.futures.wait() silently discards any exception raised inside the submitted callable. Drain stdout inline instead. Assisted-by: ClaudeCode:claude-sonnet-4.6
Assisted-by: ClaudeCode:claude-sonnet-4.6
Assisted-by: ClaudeCode:claude-opus-4.8
gaborbernat
approved these changes
Jun 13, 2026
layday
approved these changes
Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Remove the unnecessary
ThreadPoolExecutorfrom the verbose subprocess logging path inrun_subprocess. Since stderr is already merged into stdout viastderr=STDOUT, there is only one stream to drain — the thread provides no concurrency. Worse,concurrent.futures.wait()silently swallows any exception raised inside the submitted callable, so logging errors are hidden. Draining stdout inline is simpler and correctly propagates errors.Refs #1097