Repository navigation
test(server): bind HTTP fixtures to IPv4 loopback - #811
Merged
Merged
Conversation
|
Deployment failed for project pylon-marketing with the following error: Learn More: https://vercel.com/pylon-code?upgradeToPro=build-rate-limit |
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
rynfar
marked this pull request as ready for review
September 26, 2026 07:14
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NodeHttpServer.layerTestcan bind a test server to IPv6::while its Fetch client requests127.0.0.1. On macOS, another process can bind the same numeric port on IPv4, so a server seam test can receive that other listener's body. The fullserver.test.tssuite intermittently receivedreadyor an unrelated 501 response; a same-process two-listener reproduction confirmed the address-family collision.This test-only change binds server fixtures to
127.0.0.1, matching the client, across the server seam, analytics, and MCP HTTP tests. The regression reads the actual server address and verifies that a competing IPv4 bind fails withEADDRINUSE. It leaves production HTTP behavior unchanged and adds no retries or timing delays. The fixture is compatible with Effect rc.112 and rc.115 address types; on the reviewed open-PR integration stack, an additional provider-refresh seam test must use the same helper when those branches converge.The provider-refresh prerequisite #743 is already merged into
pylon. Its seam test also uses the loopback layer, so integration leaves no danglingNodeHttpServer.layerTestreference.Validation: 240 focused tests and
t3typecheck passed on the combined #743 + fix branch; scoped lint, format, and frozen install passed. Six bounded 201-test full-file runs passed after the initial change. An isolated rc.115 integration rehearsal passed 223 focused tests andt3typecheck. Independent review passed on the final combined commit. This reduces a confirmed test-fixture collision; repeated passing tests alone do not establish that every intermittent failure is eliminated.Tracks upstream catch-up issue #736 only as a test-isolation follow-up; no upstream source disposition or ledger cursor is changed.