Conversation
Fix carried governance links that resolve in the hub but break in downstream repositories. - Point hub-only workflow documentation and workflow references at canonical `main` URLs. - Validate relative links inside verbatim carried Markdown sections against universally carried files. - Cover hub-only, universal, absolute, and inline-code link cases. The full local gate passed, including 731 unit tests, live fleet audit, repository configuration check, and containerized EditorConfig, ShellCheck, and PSScriptAnalyzer checks.
Contributor
There was a problem hiding this comment.
Pull request overview
Promotes a new spec validation that rejects relative Markdown links inside verbatim-carried sections when the target is not universally carried across the fleet, preventing hub-valid links from becoming broken after carry.
Changes:
- Add a Markdown link extractor and a new
carried_relative_link_errors()gate tospec/validate.py. - Add unit tests covering accepted and rejected link shapes for the new gate.
- Update carried Governance prose to use canonical (hub) URLs where the referenced file is not universally carried.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| spec/validate.py | Adds link-target parsing and a portability check for relative links inside verbatim-carried Markdown sections. |
| scripts/tests/test_spec_validate.py | Adds unit tests validating the new carried-link portability behavior. |
| GOVERNANCE.md | Updates links in verbatim-carried Governance content to avoid downstream-broken relative targets. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Apply the executable test-file convention identified during promotion review. - Add the standard Python shebang and executable mode. - Pin the directly executed test to LF in `.gitattributes`. The complete local gate passed, including 733 tests and all container analyzers.
Owner
Author
ptr727
marked this pull request as ready for review
August 19, 2026 02:42
This was referenced Aug 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promote carried documentation link validation from
developtomain.Closes #829