Validate Carried Documentation Links - #830
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR strengthens the spec validation gate to prevent carried verbatim Markdown sections from containing relative links that resolve in the hub but would break when those sections are carried into downstream repositories.
Changes:
- Add a Markdown link scanner to
spec/validate.pyand a new validation pass to flag non-universally-carried relative link targets found in verbatim-carried sections. - Add unit tests covering core carried-relative-link acceptance/rejection cases.
- Update carried governance text to use canonical hub URLs for hub-only workflow documentation references.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| spec/validate.py | Adds parsing + validation to detect non-portable relative Markdown links inside verbatim-carried sections. |
| scripts/tests/test_spec_validate.py | Adds focused unit tests for the new carried-relative-link validation behavior. |
| GOVERNANCE.md | Replaces hub-only relative references with canonical main URLs to keep carried links valid downstream. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix carried governance links that resolve in the hub but break in downstream repositories.
mainURLs.The full local gate passed, including 731 unit tests, live fleet audit, repository configuration check, and containerized EditorConfig, ShellCheck, and PSScriptAnalyzer checks.