Drop IGNORE_GITHUB_REF From the Hosted Get-Version Task - #783
Merged
Conversation
WORKFLOW.md D3.1 states the current model: each run builds and versions the one branch it was triggered on, GITHUB_REF names it, NBGV classifies it directly, and no IGNORE_GITHUB_REF override is required. The hosted get-version-task.yml carried the override from the retired branch-matrix snippet while the inline get-version in build-release-task.yml followed D3.1, and #768's review raised the difference. The task now follows the same rule as its sibling, and its comments say why.
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns the hosted get-version-task.yml with WORKFLOW.md D3.1 by removing the legacy IGNORE_GITHUB_REF override (carried over from the retired branch-matrix model) and updating the surrounding documentation to reflect the current “one branch per run” version-classification rule.
Changes:
- Removed
IGNORE_GITHUB_REF: "true"from the NBGV step so NBGV classifies directly fromGITHUB_REF. - Updated the workflow header comments to describe the D3.1 model and why the override is no longer used.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ptr727
added a commit
that referenced
this pull request
Aug 17, 2026
… Fix (#786) Promote `develop` to `main`, carrying: - #783 Drop IGNORE_GITHUB_REF From the Hosted Get-Version Task (the hosted task follows WORKFLOW.md D3.1 like the inline get-version job already does) - #778 Name the Executable Asset for Its Project and Record the PhotoCleaner Pilot (the executable default names its archive for the project file, the publish-release snippet and doc stub carry explicit permissions, PhotoCleaner ticked as the stage 2 and 4 pilot) - #775 Record 2.0.352 in the Reusable-Workflow Rollout and Add Its Catalog Snippets - #773 Expand references/ in large skill files for progressive disclosure - #776 Make the linux host-setup scripts refuse more than one action - #782 Add PowerShell as an Optional Tool From the Microsoft Feed The release that follows is the pin PhotoCleaner's Dependabot bumps to, and PhotoCleaner's next release through it is the proof that the executable asset is named `PhotoCleaner.7z` again. Closes #769.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get-version-task.ymlfollows WORKFLOW.md D3.1 like the inlineget-versionjob inbuild-release-task.ymlalready does: one branch per run,GITHUB_REFnames it, NBGV classifies it directly, noIGNORE_GITHUB_REF. The override was carried over from the retired branch-matrix snippet, and its comments described that model. Every current caller passes the default ref, where the two spellings agree, so no behavior changes for them.Refs #769, which the promotion to
maincloses.