Skip to content

Reconcile IGNORE_GITHUB_REF between get-version-task.yml and WORKFLOW.md D3.1 #769

Description

@ptr727

The hosted .github/workflows/get-version-task.yml sets IGNORE_GITHUB_REF: "true" on its NBGV step, carried over from the catalog snippet whose comment explains it for the retired branch-matrix model ("which each matrix leg already is"). WORKFLOW.md D3.1 and "Versioning" state the current rule: each run builds a single branch, GITHUB_REF names it, NBGV classifies it directly, and no IGNORE_GITHUB_REF override is required. The inline get-version job in .github/workflows/build-release-task.yml follows D3.1 and sets no override. Copilot raised the difference on the promotion #768.

Both spellings agree while the checkout is the branch itself, which every current caller passes (ref defaults to the caller's checkout). They diverge when a caller passes a commit SHA as ref: with the override NBGV reads a detached checkout and cannot classify a public release, without it NBGV reads GITHUB_REF, so the two hosted files should state one rule. Decide which, align the other file and its comments, and add a self-test or doc line so the audit's D3.1 reading (which today grades the override as PASS and its absence as letter drift in some reports) matches WORKFLOW.md.

Found on #768 (promotion of develop at 9874122).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions