Close the P2 Skill Coverage Gaps: G9 G10 G12 - #691
Merged
Conversation
Author the four skills docs/fleet-map.md proposes: skill-lifecycle first, then audit-a-repo, workflow-ci-contract with references splits, and agent-conduct with narrow decision-moment triggers. Sweep the AGENTS.md rule map so every doc-only GOVERNANCE section carries an explicit disposition, add the kept-authority pointers to the four surfaced sections, defer the skills README to skill-lifecycle for procedure, and close the G9, G10, and G12 register rows. All four ship in one pull request at the maintainer's direction, recorded in the G9 provenance note.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR completes phase 2 of the docs/fleet-map.md adoption roadmap by adding four new fleet Skills (covering AUDIT, WORKFLOW, skill lifecycle, and conduct decision-moments), updating governance/routing docs to point at the new skill surfaces, and closing the G9/G10/G12 register entries accordingly.
Changes:
- Add four new Skills (
audit-a-repo,workflow-ci-contract,skill-lifecycle,agent-conduct) under.agents/skills/and regenerate the Claude plugin distribution under.claude-plugin/. - Update
GOVERNANCE.md,AGENTS.md, anddocs/fleet-map.mdto reflect the new skill surfacing model and mark G9/G10/G12 as closed. - Wire the new Skills into the generated Claude plugin manifest and source digest so CI
build_dist.py --checkcan validate the source/generated pairing.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| GOVERNANCE.md | Adds standard “kept authority surfaced by skill” pointers for conduct sections and Workflow YAML conventions. |
| docs/fleet-map.md | Updates scope wording, closes G9/G10/G12 register rows, and records provenance for the phase-2 packaging in one PR. |
| AGENTS.md | Annotates the rule map rows with the new skill surfacing and documents why remaining sections are doc-only by decision. |
| .agents/skills/README.md | Defers skill lifecycle procedure to the new skill-lifecycle skill. |
| .agents/skills/workflow-ci-contract/SKILL.md | New Skill summarizing WORKFLOW.md contract plus binding workflow-edit rules and routing. |
| .agents/skills/workflow-ci-contract/references/test-methodology.md | New reference doc capturing 5A/5B/5C workflow verification methodology. |
| .agents/skills/workflow-ci-contract/references/d-guarantees.md | New condensed D1–D9 guarantee catalog reference. |
| .agents/skills/skill-lifecycle/SKILL.md | New Skill documenting the source-vs-generated pipeline, regeneration/check semantics, and packaging pattern. |
| .agents/skills/audit-a-repo/SKILL.md | New Skill routing into AUDIT.md with guardrails for read-only measurement and reporting. |
| .agents/skills/agent-conduct/SKILL.md | New Skill surfacing conduct rules at narrow decision moments (done/assumption/lesson). |
| .claude-plugin/fleet-skills/.claude-plugin/plugin.json | Adds the four new Skills to the generated Claude plugin manifest. |
| .claude-plugin/fleet-skills/.source-digest | Updates the generated source digest to match the new source tree state. |
| .claude-plugin/fleet-skills/skills/workflow-ci-contract/SKILL.md | Generated plugin copy of the workflow-ci-contract skill. |
| .claude-plugin/fleet-skills/skills/workflow-ci-contract/references/test-methodology.md | Generated plugin copy of the workflow test methodology reference. |
| .claude-plugin/fleet-skills/skills/workflow-ci-contract/references/d-guarantees.md | Generated plugin copy of the D-guarantees reference. |
| .claude-plugin/fleet-skills/skills/skill-lifecycle/SKILL.md | Generated plugin copy of the skill-lifecycle skill. |
| .claude-plugin/fleet-skills/skills/audit-a-repo/SKILL.md | Generated plugin copy of the audit-a-repo skill. |
| .claude-plugin/fleet-skills/skills/agent-conduct/SKILL.md | Generated plugin copy of the agent-conduct skill. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ptr727
added a commit
that referenced
this pull request
Aug 15, 2026
…Python CI Gates (#718) Thirty-one squashes, `56f4d7d..d54862a`. 115 files, +20436/-5298. **Merge with a merge commit, never a squash, and never with `--delete-branch`.** This pull request's head is `develop` itself. ## What lands **Fleet Skills.** The `.agents/skills/` source tree, the generated `.claude-plugin/` distribution, `scripts/build_dist.py` with its `--check` gate, and `scripts/skills_install.py` with its host stamp (#676). Packaged as skills on top of the scaffold: PR review conduct and Copilot instructions upkeep (#677), comment and doc style (#678), resync-a-repo and fleet-conformance-check (#679), the per-language codestyles (#680), git commit conventions and operational vs release workflow (#681), stand up a repo (#683), and repo-worktree (#717). Coverage gaps closed in three passes (#690, #691, #692) plus the P4 sentence-length opt-in (#697). **Host setup.** The Windows host-setup tooling and its PowerShell gate (#674), the Windows bootstrap loader (#682), Docker install and upgrade on Linux and Windows with a version floor (#701, #705), a `uv` floor in `spec/host-tools.json` (#698), self-healing of a shadowing `uv`, `jq`, or `git-restore-mtime` copy (#689), node's real winget package id (#696), and a README for the Linux host-setup nuances (#710). **Python and CI.** Python tooling in CI with the script tests moved to `scripts/tests` (#704), `ruff format` adopted and gated (#709), and the PSScriptAnalyzer claim conditioned on repos that carry `.ps1` files (#686). **Conduct rules.** Triage-order and scope guardrails in pr-review-conduct (#684), `pr_review.py wait` requesting a review rather than only polling for one (#685), a tech-agnostic signed-commit verification (#708), execution rather than analogy to verify platform-specific code (#715), and a unique worktree for every task (#717). **Docs.** The fleet map and gap register with peer messaging declared (#687), mermaid flow diagrams in the kept-authority docs (#702), and the map pointed at the shipped diagrams and current tooling (#703). ## Issues this promotion closes Each landed on `develop` on its own pull request. The keyword fires only on a merge into `main`, so it sits here rather than on the feature pull requests. Closes #700 Closes #707 Closes #711 Closes #712 Closes #714 Closes #688 #699 stays open on purpose: #717 shipped the layout convention and the skill, and the physical migration of existing checkouts is still tracked there. ## Review record Every squash closed its own Copilot loop on its own pull request before merging to `develop`. This promotion carries no new content of its own, so its review is the merged tree as a whole. ## Consequence worth stating The `GOVERNANCE.md` and `AGENTS.md` sections these squashes changed become the canonical the moment this reaches `main`, and every carrying repository reads as drifted from that point until it resyncs. That is the ordinary consequence of a canonical moving rather than a defect. The Skills installer added here is also how a machine picks the new skills up, so a session that keeps restating a rule already packaged as a skill is the signal to run it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements phase 2 of the docs/fleet-map.md adoption roadmap: the four proposed skills ship, the AGENTS.md rule map carries a disposition per doc-only GOVERNANCE section, and the G9, G10, and G12 register rows close.
What ships
Deviation from the doc, recorded in the doc
fleet-map.md said each skill ships as its own pull request. All four ship here in one at the maintainer's direction, recorded in the G9 provenance note, since skill-lifecycle only needed to be authored (not merged) before the others follow it.
Verification
Generated with Claude Code