Condition PSScriptAnalyzer CI Claim on Repos Carrying .ps1 Files

[ptr727]

GOVERNANCE.md's "Running the Linters Locally" bullet unconditionally claimed CI runs PSScriptAnalyzer and linked PSScriptAnalyzerSettings.psd1, true for the hub itself but not for every downstream repo.

Hit as a real Copilot finding on both Blog#94 (a stale carried validate-task.yml never wired the step) and HomeAutomation-Config#50 (the repo carries no .ps1 files at all, so the link 404s). Neither was fixable per-repo without either breaking byte-parity on the verbatim bullet or inventing content the repo does not need, so both were replied-and-deferred as the maintainer's call.

This conditions both bullets on a repo carrying .ps1 files instead, closing the recurring gap at its source rather than continuing to defer it repo by repo through the rest of the Phase 8 rollout.

Not manifest-tracked ("Running the Linters Locally" is not a declared verbatim section in spec/files.json), so this is a hub-only prose fix with no spec/audit coupling to update.

🤖 Generated with Claude Code

[Copilot]

Pull request overview

Updates governance documentation to accurately describe when PSScriptAnalyzer is expected to run in CI and how to invoke it locally, avoiding incorrect universal claims for downstream repos that do not carry PowerShell scripts.

Changes:

• Condition the CI lint-surface description of PSScriptAnalyzer on repositories that carry *.ps1 files.
• Condition the local PSScriptAnalyzer invocation guidance similarly, clarifying applicability.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (1)

GOVERNANCE.md:242

• The PSScriptAnalyzer invocation still unconditionally passes -Settings ./PSScriptAnalyzerSettings.psd1, but the updated prose now allows for repos that carry .ps1 files without necessarily carrying that settings file. In that case this “known-working invocation” will fail immediately. Consider making the command gracefully fall back to default rules when the settings file is absent (with a warning).

- **PSScriptAnalyzer** (PowerShell, the peer of the shellcheck step, **only applies to a repo that carries `.ps1` files**, with the excluded rules and their reasons in `PSScriptAnalyzerSettings.psd1` alongside a repo that carries one):

  ```sh
  docker run --rm --pull=always -e PS_SCRIPTS="$(git ls-files '*.ps1')" -v "$PWD":/mnt --workdir /mnt mcr.microsoft.com/powershell:latest \
    pwsh -NoProfile -Command '

[ptr727]

Suppressed finding (GOVERNANCE.md:242, the unconditional -Settings ./PSScriptAnalyzerSettings.psd1 path): fixed in a914a52. Stated explicitly that a repo carrying .ps1 files also carries PSScriptAnalyzerSettings.psd1 alongside them, rather than adding fallback logic to the invocation - the rest of this doc's required-baseline-file pattern (.editorconfig-checker.json, .gitattributes, etc.) doesn't soften on absence either, so a paired-requirement statement is the consistent fix.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.